Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding June, August and September Executive Council meeting minutes #110

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

tracykteal
Copy link
Collaborator

Adding the June, August and September Executive Council meeting minutes.

@willingc
Copy link
Collaborator

@lwasser If you land #111, we should be able to rerun this PR and have the precommit fix the whitespace.

@lwasser
Copy link
Member

lwasser commented Nov 14, 2024

oooh thank you all. The way we have precommit setup, we can use pre-commit.ci autofix to fix this pr. let me run it now. that should do the trick. I really appreciate all the troubleshooting here. thank you so much.

@lwasser
Copy link
Member

lwasser commented Nov 14, 2024

pre-commit.ci autofix

@lwasser
Copy link
Member

lwasser commented Nov 14, 2024

thank you @tracykteal let's merge this puppy 🐶

@lwasser lwasser merged commit b9a1d0d into pyOpenSci:main Nov 14, 2024
3 checks passed
@lwasser
Copy link
Member

lwasser commented Nov 14, 2024

@lwasser If you land #111, we should be able to rerun this PR and have the precommit fix the whitespace.

@willingc i'm SO SO appreciative of this pr. If you are ok with it, i'd rather not merge it. If we autofix pr's, that is good, BUT if someone needs to add commits to the pr after it's been autofixed, they'll have to do a force push. I worry that will be confusing to contributors not that we have that many contribs to this repo.

i'm open to discuss it further as I don't mind a force push if I remember to do it :) but all of our other repos have things set up to not auto-fix, and then we can just run it before merging. that workshop seems to work nicely for pyOpenSci if you are ok with it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants