BUG: Convert color space before saving #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PDF contained an image in PA mode: * P: 8-bit pixels, mapped to any other mode using a color palette * PA: P with alpha See #1801
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
=======================================
Coverage 93.38% 93.39%
=======================================
Files 34 34
Lines 6604 6612 +8
Branches 1300 1301 +1
=======================================
+ Hits 6167 6175 +8
Misses 285 285
Partials 152 152
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
is the PNG the best choice or should we use JPEG2000? |
|
@pubpub-zz I don't know where. But with my fix it looks good now :-) |
|
Maybe I should add some extracted images + make a visual diff 🤔 It's currently too easy to silently break something here |
pubpub-zz
reviewed
Apr 18, 2023
MartinThoma
added a commit
that referenced
this pull request
Apr 23, 2023
Bug Fixes (BUG) - Convert color space before saving (#1802) Documentation (DOC) - PDF/A (#1807) - Use append instead of add_page - Document core mechanics of pypdf (#1783) [Full Changelog](3.8.0...3.8.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PDF contained an image in PA mode:
See #1801