-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Document core mechanics of pypdf #1783
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1783 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 34 34
Lines 6612 6614 +2
Branches 1301 1301
=======================================
+ Hits 6175 6177 +2
Misses 285 285
Partials 152 152
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@pubpub-zz I think I'm happy now. Could you please check if it is correct / makes sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds good to me.
Perhaps adding some reference to the pdf ref (1.7? 2.0?)
Schön 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice documentation addition!
I don't know pypdf
enough yet to make many constructive suggestions,
but elements could be added later on,
and it's definitively a good start!
Bug Fixes (BUG) - Convert color space before saving (#1802) Documentation (DOC) - PDF/A (#1807) - Use append instead of add_page - Document core mechanics of pypdf (#1783) [Full Changelog](3.8.0...3.8.1)
I want to document how pypdf reads/writes PDF files
For reviewers