Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add Polygon annotation #1557

Merged
merged 2 commits into from
Jan 16, 2023
Merged

ENH: Add Polygon annotation #1557

merged 2 commits into from
Jan 16, 2023

Conversation

MartinThoma
Copy link
Member

See #107

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Base: 91.79% // Head: 91.81% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (e1b9ffd) compared to base (f0c0a1d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
+ Coverage   91.79%   91.81%   +0.02%     
==========================================
  Files          33       33              
  Lines        6093     6111      +18     
  Branches     1200     1203       +3     
==========================================
+ Hits         5593     5611      +18     
  Misses        323      323              
  Partials      177      177              
Impacted Files Coverage Δ
pypdf/generic/_annotations.py 97.43% <100.00%> (+0.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit f494e61 into main Jan 16, 2023
@MartinThoma MartinThoma deleted the polygon-annotation branch January 16, 2023 20:07
MartinThoma added a commit that referenced this pull request Jan 22, 2023
New Features (ENH):
-  Add page label support to PdfWriter (#1558)
-  Accept inline images with space before EI (#1552)
-  Add circle annotation support (#1556)
-  Add polygon annotation support (#1557)
-  Make merging pages produce a deterministic PDF (#1542, #1543)

Bug Fixes (BUG):
-  Fix error in cmap extraction (#1544)
-  Remove erroneous assertion check (#1564)
-  Fix dictionary access of optional page label keys (#1562)

Robustness (ROB):
-  Set ignore_eof=True for read_until_regex (#1521)

Documentation (DOC):
-  Paper size (#1550)

Developer Experience (DEV):
-  Fix broken combination of dependencies of docs.txt
-  Annotate tests appropriately (#1551)

[Full Changelog](3.2.1...3.3.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant