Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Meta Quest compatible" flag #98

Conversation

FluorescentHallucinogen
Copy link
Contributor

@ghost
Copy link

ghost commented Jul 11, 2022

Thanks FluorescentHallucinogen for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@FluorescentHallucinogen
Copy link
Contributor Author

@jgw96 @JudahGabriel This pull request is ready to review and merge. 😉

@JudahGabriel
Copy link
Collaborator

@amrutha95 @jgw96 Have a look at this?

@amrutha95
Copy link
Contributor

Hey @FluorescentHallucinogen , thank you so much for this PR! We are just waiting on talking to Meta who we've been partnering with to create the current Meta Quest packaging service. Will keep you updated.

@FluorescentHallucinogen
Copy link
Contributor Author

@amrutha95

We are just waiting on talking to Meta

FYI, I was in close contact with @jacobrossi and @pampas93 from the Meta team while developing the related pull request for Bubblewrap to ensure that generated APKs meet all requirements and successfully pass all server-side validations for publishing to App Lab and Oculus Store. I.e. this feature already implemented in Bubblewrap 1.18.0, and this pull request only needed for adding the corresponding UI to PWABuilder. It doesn't remove anything (e.g. ovr-platform-util) from PWABuilder (this can be done later in a separate pull request). So IMO currently there is nothing that prevents this pull request from being reviewed and merged. 😉

@amrutha95
Copy link
Contributor

@khmyznikov or I will get this tested and merged ASAP.

@khmyznikov
Copy link
Contributor

@khmyznikov or I will get this tested and merged ASAP.

Works for me

@khmyznikov khmyznikov merged commit 7a41e3b into pwa-builder:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate APK for Meta Quest using Bubblewrap
4 participants