-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Meta Quest compatible" flag #98
Add "Meta Quest compatible" flag #98
Conversation
Thanks FluorescentHallucinogen for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@jgw96 @JudahGabriel This pull request is ready to review and merge. 😉 |
@amrutha95 @jgw96 Have a look at this? |
Hey @FluorescentHallucinogen , thank you so much for this PR! We are just waiting on talking to Meta who we've been partnering with to create the current Meta Quest packaging service. Will keep you updated. |
FYI, I was in close contact with @jacobrossi and @pampas93 from the Meta team while developing the related pull request for Bubblewrap to ensure that generated APKs meet all requirements and successfully pass all server-side validations for publishing to App Lab and Oculus Store. I.e. this feature already implemented in Bubblewrap 1.18.0, and this pull request only needed for adding the corresponding UI to PWABuilder. It doesn't remove anything (e.g. |
@khmyznikov or I will get this tested and merged ASAP. |
Works for me |
Fixes pwa-builder/PWABuilder#3154.
See also pwa-builder/PWABuilder#3162.