Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #615 Add Meta Quest support #704

Merged

Conversation

FluorescentHallucinogen
Copy link
Contributor

@FluorescentHallucinogen FluorescentHallucinogen commented Jun 14, 2022

This pull request adds a --metaquest flag for generating universal APK that open TWA (Trusted Web Activity) on regular Android devices and open Meta Quest Browser on Meta Quest devices.

This will allow to abandon ovr-platform-util in favor of Bubblewrap (e.g. in PWABuilder).

@andreban andreban requested review from andreban and PEConn June 14, 2022 10:46
@FluorescentHallucinogen
Copy link
Contributor Author

@andreban

Is there a way to change android:minSdkVersion="19" to 23, if --metaquest flag is passed? If so, how?

This is not needed to run the app on Meta Quest device (I've tested), this is needed only to publish the app in the Oculus Store and App Lab.

@FluorescentHallucinogen
Copy link
Contributor Author

Is there a way to change android:minSdkVersion="19" to 23, if --metaquest flag is passed? If so, how?

@andreban It seems I've found a solution. PTAL.

@FluorescentHallucinogen FluorescentHallucinogen changed the title Draft: Fix #615 Add Meta Quest support Fix #615 Add Meta Quest support Jun 19, 2022
@FluorescentHallucinogen
Copy link
Contributor Author

@andreban The pull request is ready to review and merge. 😉

@andreban
Copy link
Member

@PEConn would you mind taking a look too?

@FluorescentHallucinogen FluorescentHallucinogen changed the title Fix #615 Add Meta Quest support Draft: Fix #615 Add Meta Quest support Jun 21, 2022
@FluorescentHallucinogen FluorescentHallucinogen changed the title Draft: Fix #615 Add Meta Quest support Fix #615 Add Meta Quest support Jun 29, 2022
@andreban andreban requested review from andreban and PEConn June 29, 2022 09:23
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@PEConn PEConn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for your work on it.

@andreban andreban merged commit f8563a8 into GoogleChromeLabs:main Jun 29, 2022
@FluorescentHallucinogen
Copy link
Contributor Author

@PEConn @andreban Could you please release a new version of Bubblewrap that contains this pull request? It's needed for further work on PWABuilder.

@PEConn
Copy link
Collaborator

PEConn commented Jul 5, 2022

Done, the changes should be in version 1.18.0 of core and cli.

@FluorescentHallucinogen
Copy link
Contributor Author

@PEConn Thanks!

BTW, just noticed that version 1.18.0 is not listed at https://github.com/GoogleChromeLabs/bubblewrap/releases.

@PEConn
Copy link
Collaborator

PEConn commented Jul 6, 2022

It's now listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants