-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #615 Add Meta Quest support #704
Fix #615 Add Meta Quest support #704
Conversation
packages/core/template_project/app/src/main/AndroidManifest.xml
Outdated
Show resolved
Hide resolved
Is there a way to change This is not needed to run the app on Meta Quest device (I've tested), this is needed only to publish the app in the Oculus Store and App Lab. |
@andreban It seems I've found a solution. PTAL. |
@andreban The pull request is ready to review and merge. 😉 |
@PEConn would you mind taking a look too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for your work on it.
Done, the changes should be in version 1.18.0 of |
@PEConn Thanks! BTW, just noticed that version |
It's now listed. |
This pull request adds a
--metaquest
flag for generating universal APK that open TWA (Trusted Web Activity) on regular Android devices and open Meta Quest Browser on Meta Quest devices.This will allow to abandon
ovr-platform-util
in favor of Bubblewrap (e.g. in PWABuilder).