Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pvvx to Manufacturer Name #50

Closed

Conversation

krzysztof-kwitt
Copy link

@krzysztof-kwitt krzysztof-kwitt commented Feb 4, 2024

Hello,

It is difficult to recognize what CFW we have on a specific device, so I suggest that we also add the author's name to the manufacturer name field, which will make it easy to find out who the firmware comes from.

For now, it is possible to recognize the author only on the basis of OTA Upgrade (0x19) cluster, which is not very obvious and user-friendly.

I'm not sure what implications this will have, but I think it's worth discussing how we can recognize what CFW we have on the device in a more user-friendly way.

CC: @devbis

#define ZCL_BASIC_MODEL_ID {10,'L','Y','W','S','D','0','3','M','M','C'}

#elif BOARD == BOARD_CGDK2

#define ZCL_BASIC_MFG_NAME {8,'Q','i','n','g','p','i','n','g'} // Qingping
#define ZCL_BASIC_MFG_NAME {13,'Q','i','n','g','p','i','n','g''/','p','v','v','x'} // Qingping

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing , between 'g' '/'; same issue exists on all following ZCL_BASIC_MFG_NAME

#define ZCL_BASIC_MODEL_ID {9,'M','H','O','-','C','4','0','1','N'} // MHO-C401N

#elif BOARD == BOARD_TS0201_TZ3000

#define ZCL_BASIC_MFG_NAME {4,'T','u','y','a'} // Tuya
#define ZCL_BASIC_MFG_NAME {10,'T','u','y','a''/','p','v','v','x'} // Tuya

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a new length of 9, not 10.

@pvvx
Copy link
Owner

pvvx commented Feb 4, 2024

ZigBee Cluster Library Specification
3.2.2.2.5 ManufacturerName At tribute
The ManufacturerName attribute is a maximum of 32 bytes in length and specifies the name of the manufacturer as a ZigBee character string.

I'm not a 'manufacturer'.
Don't confuse Zigbee 3.0 standards with Tuya quirks

@krzysztof-kwitt krzysztof-kwitt changed the title Add pvvx to manufacturer name Add pvvx to Manufacturer name Feb 4, 2024
@krzysztof-kwitt krzysztof-kwitt changed the title Add pvvx to Manufacturer name Add pvvx to Manufacturer Name Feb 4, 2024
@krzysztof-kwitt
Copy link
Author

krzysztof-kwitt commented Feb 4, 2024

I wanted to update the field. This is what it looks like in Zigbee2MQTT.
Screenshot 2024-02-04 at 21 07 19
Screenshot 2024-02-04 at 21 07 30

This field can be used as a fingerprint in Zigbee2MQTT.
https://github.com/Koenkk/zigbee-herdsman-converters/blob/0fcaeef8210c6c2635abe85c37e2a26c6f17d4f3/src/lib/types.ts#L35-L40

The word manufacturer in this case can be interpreted in different ways.

  • The person who physically produced the physical hardware.
  • The person who produced the digital software.
    In my opinion, this fragment of the specification does not specify that it is to be the manufacturer of the physical goods. In most cases, the manufacturer of the digital and physical parts is the same company, but in the case of Tuya, as in this case, we have a different software manufacturer and a different hardware manufacturer.

This is important for me to solve problems like: Koenkk/zigbee2mqtt#21165
Do you have another idea for recognizing whether your CFW or CFW authored by @devbis is installed? I am thinking about recognition based on software version (static list) for already released versions of your and devbis CFW. Newer versions will be recognized based on the new Zigbee manufacturer's name

@devbis
Copy link

devbis commented Feb 4, 2024

@krzysztof-kwitt A better option is to add pvvx to device model name as z2m uses zigbeeModel as a primary recognition property. E.g. LYWSD03MMC/pvvx

@pvvx
Copy link
Owner

pvvx commented Feb 4, 2024

Due to the distribution by "ModelIdentifier" and "ManufacturerName", many Tuya Zigbees do not work. The firmware version is different, but the name is the same.

@devbis
Copy link

devbis commented Feb 4, 2024

It is applicable only to original Tuya firmwares with proprietary cluster with datapoints. Doesn't make sense for custom firmwares.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants