-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pvvx to Manufacturer Name #50
Add pvvx to Manufacturer Name #50
Conversation
src/sensorEpCfg.c
Outdated
#define ZCL_BASIC_MODEL_ID {10,'L','Y','W','S','D','0','3','M','M','C'} | ||
|
||
#elif BOARD == BOARD_CGDK2 | ||
|
||
#define ZCL_BASIC_MFG_NAME {8,'Q','i','n','g','p','i','n','g'} // Qingping | ||
#define ZCL_BASIC_MFG_NAME {13,'Q','i','n','g','p','i','n','g''/','p','v','v','x'} // Qingping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing ,
between 'g'
'/'
; same issue exists on all following ZCL_BASIC_MFG_NAME
src/sensorEpCfg.c
Outdated
#define ZCL_BASIC_MODEL_ID {9,'M','H','O','-','C','4','0','1','N'} // MHO-C401N | ||
|
||
#elif BOARD == BOARD_TS0201_TZ3000 | ||
|
||
#define ZCL_BASIC_MFG_NAME {4,'T','u','y','a'} // Tuya | ||
#define ZCL_BASIC_MFG_NAME {10,'T','u','y','a''/','p','v','v','x'} // Tuya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a new length of 9, not 10.
ZigBee Cluster Library Specification I'm not a 'manufacturer'. |
I wanted to update the field. This is what it looks like in Zigbee2MQTT. This field can be used as a fingerprint in Zigbee2MQTT. The word
This is important for me to solve problems like: Koenkk/zigbee2mqtt#21165 |
@krzysztof-kwitt A better option is to add |
Due to the distribution by "ModelIdentifier" and "ManufacturerName", many Tuya Zigbees do not work. The firmware version is different, but the name is the same. |
It is applicable only to original Tuya firmwares with proprietary cluster with datapoints. Doesn't make sense for custom firmwares. |
Hello,
It is difficult to recognize what CFW we have on a specific device, so I suggest that we also add the author's name to the manufacturer name field, which will make it easy to find out who the firmware comes from.
For now, it is possible to recognize the author only on the basis of OTA Upgrade (
0x19
) cluster, which is not very obvious and user-friendly.I'm not sure what implications this will have, but I think it's worth discussing how we can recognize what CFW we have on the device in a more user-friendly way.
CC: @devbis