DApp-1708 added support for new css variables and semantics in blocks components #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitmalhotra1420
added
the
Quick PR
|
All looks good. |
|
All looks good. |
|
mishramonalisha76
suggested changes
Jul 11, 2024
src/blocks/box/Box.types.ts
Outdated
| @@ -21,15 +21,15 @@ export type BoxResponsiveProps = { | |||
| /* Sets flex-direction css property */ | |||
| flexDirection?: ResponsiveProp<CSSProperties['flexDirection']>; | |||
| /* Sets gap between the elements */ | |||
| gap?: ResponsiveProp<SpaceType>; | |||
| gap?: ResponsiveProp<BlocksSpaceType>; | |||
There was a problem hiding this comment.
gap cant take input for all four sides, we should define a different type for it
There was a problem hiding this comment.
added a new type. will remove the previous type afterwards because that will break thing s right now.
|
All looks good. |
mishramonalisha76
approved these changes
Jul 11, 2024
abhishek-01k
approved these changes
Jul 11, 2024
corlard3y
added a commit
that referenced
this pull request
Jul 16, 2024
… components (#1716) * update changes * add props type * update version and remove on dash * added support for new css variables * deleted curropted file * added gap type --------- Co-authored-by: corlard3y <[email protected]>
corlard3y
added a commit
that referenced
this pull request
Jul 16, 2024
… components (#1716) * update changes * add props type * update version and remove on dash * added support for new css variables * deleted curropted file * added gap type --------- Co-authored-by: corlard3y <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Ticket Number
Description
Type of Change
Checklist
Frontend Guidelines
Build & Testing
Screenshots/Video with Explanation
Before: Explain the previous behavior
After: What's changed now
Additional Context
Review & Approvals
Notes