Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the color and background css property and use the new semantics in all design system components #1708

Closed
rohitmalhotra1420 opened this issue Jul 10, 2024 · 0 comments
Closed

Fix the color and background css property and use the new semantics in all design system components #1708

rohitmalhotra1420 opened this issue Jul 10, 2024 · 0 comments
Assignees
@rohitmalhotra1420

Comments

@rohitmalhotra1420
Copy link
Collaborator

rohitmalhotra1420 commented Jul 10, 2024 •
edited
Loading

  • All the blocks components should use the new theme semantics internally and accept the new semantics as props for color and backgroundColor.
  • Fix all the occurrences of the design system components in the main codebase to use the semanticd.
  • Remove the blocks colors and theme mode colors types.
  • Remove the getBlocksColor function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohitmalhotra1420 rohitmalhotra1420

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rohitmalhotra1420