Skip to content
This repository has been archived by the owner on Sep 24, 2019. It is now read-only.

(maint) fix acceptance bundle #72

Merged
merged 12 commits into from
Apr 5, 2017
Merged

(maint) fix acceptance bundle #72

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b160a34
(maint) remove bundler/gem_tasks from Rakefile
Apr 3, 2017
cba04b5
(maint) fix acceptance install for non-whole rake version strings
Apr 3, 2017
f947535
(maint) fix previous acceptance bundler on-sut removal
Apr 3, 2017
6204ccc
(maint) require < rake 12; we have a bug there
Apr 4, 2017
a65a3d9
(maint) fix acceptance bundle
Apr 4, 2017
a8dc77e
(maint) fix acceptance bundle nokogiri ruby < 2
Apr 4, 2017
bb863ad
(maint) argh. some rubygem versions don't have --no-document
Apr 4, 2017
829c32a
(maint) acceptance: force rake gem install over system rake
Apr 4, 2017
15fe257
(maint) rake version in Gemfile should not matter
Apr 4, 2017
4a7b574
(maint) acceptance: install implied rake version on sut
Apr 4, 2017
73a1bed
(maint) who knew gem install could be so complicated?
Apr 5, 2017
974dc6c
(maint) re-add Gemfile.lock to .gitignore
Apr 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion acceptance/pre-suite/01_install_rototiller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
end
scp_to(sut, gem_name, gem_name)

rake_version = `rake --version`.split[2]
if ENV['RAKE_VER']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you're only relying on the 'rake --version' command now... should we remove this if statement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. but i think we want that there so it'll just install whatever version of rake on the SUT if we aren't using rake at all, locally, for instance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should probably check if $(which rake) or similar, but i dunno if i care enough to fix that for now.

on(sut, "gem install rake --no-document --version #{ENV['RAKE_VER']}")
on(sut, "gem install rake --no-document --version #{rake_version}")
else
on(sut, "gem install --no-document rake")
end
Expand Down