(maint) fix acceptance bundle #72
Conversation
* i guess we never got around to adding Gem building tasks
* previous change did not account for when x.y.z rake version strings were not specified.
* a previous commit removed the bundle on the SUT * forgot to commit the changes to the test to not specify bundle exec
er0ck
force-pushed
the
fix/stable/maint-fix_acceptance_no_bundler_net-ssh_pin
branch
from
7b6885e to
d32fc12
Compare
|
@puppetlabs-jenkins retest this please |
er0ck
changed the title
* we can't commit a Gemfile.lock as we sweep one of our deps (rake) * unit test job uses bundle install not bundle update * pin some deps here. next major we'll require ruby > 2
er0ck
force-pushed
the
fix/stable/maint-fix_acceptance_no_bundler_net-ssh_pin
branch
from
d32fc12 to
a65a3d9
Compare
er0ck
changed the title
| @@ -8,8 +8,9 @@ | |||
| end | |||
| scp_to(sut, gem_name, gem_name) | |||
|
|
|||
| rake_version = `rake --version`.split[2] | |||
| if ENV['RAKE_VER'] | |||
There was a problem hiding this comment.
It looks like you're only relying on the 'rake --version' command now... should we remove this if statement?
There was a problem hiding this comment.
good point. but i think we want that there so it'll just install whatever version of rake on the SUT if we aren't using rake at all, locally, for instance.
There was a problem hiding this comment.
it should probably check if $(which rake) or similar, but i dunno if i care enough to fix that for now.
|
@puppetlabs-jenkins retest this please |
* force installs of rake to overwrite exes in osx
|
so this is failing ubuntu16 against rake 0.9 only. this is expected and will be remedied when this is merged: https://github.com/puppetlabs/ci-job-configs/pull/2651 |
er0ck
force-pushed
the
fix/stable/maint-fix_acceptance_no_bundler_net-ssh_pin
branch
from
d63d590 to
974dc6c
Compare
No description provided.