Fix the postgresql::postgresql_password() function

[smortex]

The changes in #1512 introduced a regression when a hash value is not
explicitly passed:

Puppet Server Error: Evaluation Error: Error while evaluating a Function Call, failed to coerce org.jruby.RubySymbol to java.lang.String

Fixes #1528

[bastelfreak]

@smortex thanks for the fix, I noticed the error as well. Any chance you can add an easy test for it?

[smortex]

@smortex thanks for the fix, I noticed the error as well. Any chance you can add an easy test for it?

Not sure how to do this given call_function belongs to Puppet itself. Do you have an idea how we can improve this (other that adding checks on the Puppet side)?

Also while investigating this I found another bug, which I am working on ATM. Don't release a 10.0.1 too soon 🙃 !

[smortex]

@smortex thanks for the fix, I noticed the error as well. Any chance you can add an easy test for it?

Also there is already extensive testing of the postgresql::postgresql_password() function where the call without explicit hash does not fail. Maybe some code run by jruby fail but the bad behavior is not triggered by MRI 🤷? I have not found how to reproduce this outside of the context of puppetserver compiling a catalog.

[kenyon]

I still get this error with this PR's branch, is that the other bug you found @smortex?

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: no parameter named 'instance' (file: /etc/puppetlabs/code/environments/production/modules/postgresql/manifests/server/extension.pp, line: 83) on Postgresql_psql[puppetdb: CREATE EXTENSION "pg_trgm"] (file: /etc/puppetlabs/code/environments/production/modules/postgresql/manifests/server/extension.pp, line: 83) on node lithium.kenyonralph.com

[kenyon]

Ah nevermind, just needed to run sudo puppet generate types (non-PE). Need to add that to my regular deploy command.