Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible password encryption in pg hba conf #1512

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Flexible password encryption in pg hba conf #1512

merged 2 commits into from
Sep 7, 2023

Conversation

cruelsmith
Copy link
Contributor

@cruelsmith cruelsmith commented Sep 6, 2023 •
edited
Loading

Summary

  • ensure that default password encryption is also used in default pg hba conf
  • ensure that postgresql::postgresql_password respect the module default password encryption

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

fixes #1465

replace #1479

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

bastelfreak
bastelfreak approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@bastelfreak bastelfreak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@bastelfreak bastelfreak merged commit 65ca3ae into puppetlabs:main Sep 7, 2023
40 checks passed
@cruelsmith cruelsmith mentioned this pull request Sep 11, 2023
Merged
5 tasks
smortex added a commit that referenced this pull request Oct 11, 2023
@smortex
Fix the postgresql::postgresql_password() function
608d8d7 
The changes in #1512 introduced a regression when a hash value is not
explicitly passed:

```
Puppet Server Error: Evaluation Error: Error while evaluating a Function Call, failed to coerce org.jruby.RubySymbol to java.lang.String
```

Fixes #1528
@smortex smortex mentioned this pull request Oct 11, 2023
Merged
vaol pushed a commit to vaol/puppetlabs-postgresql that referenced this pull request Oct 13, 2024
@smortex @vaol
Fix the postgresql::postgresql_password() function
69b28c6 
The changes in puppetlabs#1512 introduced a regression when a hash value is not
explicitly passed:

```
Puppet Server Error: Evaluation Error: Error while evaluating a Function Call, failed to coerce org.jruby.RubySymbol to java.lang.String
```

Fixes puppetlabs#1528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonHoenscheid SimonHoenscheid SimonHoenscheid approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher alexjfisher is a code owner

@deric deric Awaiting requested review from deric deric is a code owner

@ekohl ekohl Awaiting requested review from ekohl ekohl is a code owner

@smortex smortex Awaiting requested review from smortex smortex is a code owner

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default HBA does not take scram into account
4 participants
@cruelsmith @bastelfreak @SimonHoenscheid @ia-content