Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for apt::source #432

Merged
merged 2 commits into from
Feb 21, 2015
Merged

Conversation

underscorgan
Copy link

  • Update release to default to $::lsbdistcodename
  • Default include_src to false
  • Validate more things!
  • Stop redefining variables from apt::params

@underscorgan underscorgan added this to the 2.0 milestone Feb 20, 2015
@underscorgan
Copy link
Author

More will need to be done on apt::source once #428 is merged

@underscorgan
Copy link
Author

Also, I don't know if we still want to turn key_* into a hash since we can't use the splats until 3.x.

}

file { "${name}.list":
ensure => $ensure,
path => "${sources_list_d}/${name}.list",
path => "${apt::params::sources_list_d}/${name}.list",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use $::apt::sources_list_d?

@underscorgan
Copy link
Author

This includes commit from #435.

Morgan Haskel added 2 commits February 21, 2015 15:26
* Update `release` to default to `$::lsbdistcodename`
* Default `include_src` to false
* Validate more things!
* Stop redefining variables from `apt::params`
May as well use the define since we added it
daenney added a commit that referenced this pull request Feb 21, 2015
@daenney daenney merged commit c4981a0 into puppetlabs:next Feb 21, 2015
@underscorgan underscorgan deleted the source_cleanup branch May 8, 2015 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants