apt: Add apt::setting defined type. #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daenney
force-pushed
the
daenney/apt-setting
branch
2 times, most recently
from
581e283 to
21ff418
Compare
| } | ||
|
|
||
| if $type == 'list' { | ||
| $_priority = '' |
There was a problem hiding this comment.
Should we have a warning if $type == 'list' and $priority, or is this obvious to apt users?
There was a problem hiding this comment.
Priority doesn't make sense for list, it's not a concept that sources recognise so there's no real use or need for it. We should document that we ignore priority in that case.
There was a problem hiding this comment.
Ok, cool. At some point there will be massive doc updates, I ... haven't been keeping up with that.
|
@daenney commented, assigned back to you for response. |
Merged
This is a 'base' type. It's a simple wrapper around a file which takes `type`, `ensure`, `content`, `source` and `file_perms`. It is intended for usage by `apt::conf`, `apt::source` and an upcoming `apt::pref`.
daenney
force-pushed
the
daenney/apt-setting
branch
from
21ff418 to
76c88af
Compare
underscorgan
pushed a commit
that referenced
this pull request
Feb 21, 2015
apt: Add apt::setting defined type.
|
Thanks @daenney ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 'base' type. It's a simple wrapper around a file which takes
type,ensure,content,sourceandfile_perms. It is intended for usage byapt::conf,apt::sourceand an upcomingapt::pref.