Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RandomSleep to 10periodic #374

Merged
merged 1 commit into from
Oct 14, 2014

Conversation

bschlief
Copy link

This is a refresh of the merge request as proposed by @frankatwork in #308. It incorporates the review comments by @daenney.

@daenney
Copy link

daenney commented Oct 13, 2014

This looks good. However, on the template I would prefer not a single line but:

<%- unless @randomsleep.nil? -%>
APT::Periodic::RandomSleep "<%= @randomsleep %>";
<%- end -%>

The %- will remove unnecessary white space and the thing becomes a bit more readable as a result of being split over a few lines.

unless is the 'nicer' way of doing if not (which also works in Puppet DSL by the way).

@bschlief
Copy link
Author

Terrific! I'll make those changes and squash the commits together. Great tip about "<%-". I hadn't seen that before.

@daenney
Copy link

daenney commented Oct 13, 2014

Thanks. I forgot one thing, I'd appreciate an entry in the README about this parameter and a small explanation about it. Look at line 278 and below.

@bschlief
Copy link
Author

Sure! I updated it. Should have come up with that on my own. For shame! :)

daenney added a commit that referenced this pull request Oct 14, 2014
Add support for RandomSleep to 10periodic
@daenney daenney merged commit 2b84dd1 into puppetlabs:master Oct 14, 2014
@daenney
Copy link

daenney commented Oct 14, 2014

Thanks you for you contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants