Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RandomSleep option #308

Closed
wants to merge 4 commits into from

Conversation

frankatwork
Copy link

Add option to change the RandomSleep option in 10periodic

@daenney
Copy link

daenney commented Jun 6, 2014

A few things:

  • Can we move away from "NONE" in favour of undef? It would allow you to go randomsleep.nil? in the template to check if it is set. I know dl_limit uses "NONE" too but I'd rather not add any more code that does that;
  • randomsleep is not being validated, no validate_ functions are being called to check the input;
  • You add a test to check for the behaviour if randomsleep is set, but you don't have a test for the NONE/undef scenario;
  • It should be squashed into one commit before we merge.

@daenney
Copy link

daenney commented Aug 3, 2014

This commit hasn't received any attention for two months, I'm going to close it for now. Feel free to reopen it once rebased and the issues have been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants