Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed proxy_host default value from true to undef. fixes #211 #215

Merged
merged 3 commits into from
Feb 25, 2014

Conversation

lotherk
Copy link

@lotherk lotherk commented Jan 29, 2014

proxy_host shouldn't be boolean since a type validator as in foreman would not allow to set a proxy.

@lotherk
Copy link
Author

lotherk commented Jan 29, 2014

Sorry, I meant from false to undef.

@daenney
Copy link

daenney commented Feb 21, 2014

Imho this is solid, the defaulting to false in a lot of the code is weird anyway.

hunner added a commit that referenced this pull request Feb 25, 2014
changed proxy_host default value from true to undef. fixes #211
@hunner hunner merged commit 0e82e54 into puppetlabs:master Feb 25, 2014
@LukasAud LukasAud added the bugfix label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants