Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy_host shouldn't be boolean as it won't work in foreman #211

Closed
lotherk opened this issue Jan 16, 2014 · 0 comments
Closed

proxy_host shouldn't be boolean as it won't work in foreman #211

lotherk opened this issue Jan 16, 2014 · 0 comments

Comments

@lotherk
Copy link

lotherk commented Jan 16, 2014

proxy_host shouldn't be boolean as it can not be used as a paramterized class in foreman due to foreman's parameter validation.

proxy_host should be undef by default and the switch case to set ensure should be changed from

..
false => absent
..

to
..
undef => absent
..

this would make it possible to set the default value (in foreman) to an empty string meaning not adding a proxy.
lotherk pushed a commit to lotherk/puppetlabs-apt that referenced this issue Jan 29, 2014
changed proxy_host default value from false to undef. fixes puppetlab…
0207fcd 
…s#211
@hunner hunner closed this as completed in bbfa2cf Feb 25, 2014
hunner added a commit that referenced this issue Feb 25, 2014
@hunner
Merge pull request #215 from lotherk/proxy_val_no_boolean
0e82e54 
changed proxy_host default value from true to undef. fixes #211
hunner pushed a commit to hunner/puppetlabs-apt that referenced this issue Feb 25, 2014
@hunner
changed proxy_host default value from false to undef. fixes puppetlab…
334f403 
…s#211

(cherry picked from commit 0207fcd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lotherk