Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert menu icon to white #1445

Merged
merged 3 commits into from Sep 9, 2017
Merged

Revert menu icon to white #1445

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afd90bb
Revert menu icon to white
Sep 7, 2017
c4dad9c
Fix indentation space
Sep 7, 2017
7d1c9f8
Add comment about generic style
Sep 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions public/stylesheet/pumpio.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ body {
width: auto;
}

.navbar .btn-navbar span {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be more clear if it targeted .fa.fa-bars

Copy link
Author

@ghost ghost Sep 7, 2017 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think specifics styles are harder to maintain and adds unnecessary complexity, the result is the same.

If in the future changes the icon name no need change styles only replace the class or if changes the icon family only need to change classes

https://stackoverflow.com/questions/2281766/generic-vs-specific-element-styles-for-maintainability

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be okay with that if you add a comment above saying what this applies to. Otherwise future readers may have the same question I did ("what does this even apply to?")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made

color: white;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two spaces, not four, for consistency with surrounding lines

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have emacs configuration by default in four XD, I will change

}

.navbar .nav .dropdown-toggle .caret {
margin-top: 10px;
}
Expand Down