Revert menu icon to white #1445
Conversation
|
I can't figure out what this actually changes? I ran |
|
You are logout? |
|
Ahhh, thanks. It only appears on small viewports too. Reviewing. |
public/stylesheet/pumpio.css
Outdated
| @@ -35,6 +35,10 @@ body { | |||
| width: auto; | |||
| } | |||
|
|
|||
| .navbar .btn-navbar span { | |||
| color: white; | |||
There was a problem hiding this comment.
Two spaces, not four, for consistency with surrounding lines
There was a problem hiding this comment.
Sorry, I have emacs configuration by default in four XD, I will change
public/stylesheet/pumpio.css
Outdated
| @@ -35,6 +35,10 @@ body { | |||
| width: auto; | |||
| } | |||
|
|
|||
| .navbar .btn-navbar span { | |||
There was a problem hiding this comment.
This would be more clear if it targeted .fa.fa-bars
There was a problem hiding this comment.
I think specifics styles are harder to maintain and adds unnecessary complexity, the result is the same.
If in the future changes the icon name no need change styles only replace the class or if changes the icon family only need to change classes
https://stackoverflow.com/questions/2281766/generic-vs-specific-element-styles-for-maintainability
There was a problem hiding this comment.
I'd be okay with that if you add a comment above saying what this applies to. Otherwise future readers may have the same question I did ("what does this even apply to?")
ghost
deleted the
No description provided.