Stop filtering on search token when finding applicable issues #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might be running very quickly after the issue was created and it might not yet be indexed. Instead, just list the latest 100 issues and filter on exact title format instead. The current rate of issue creation is low enough that the latest 100 issues should safely include all open upgrade issues. Fixes #291 We'll continue to use the token for issue de-duplication as this only happens once per day and so is reliably in the GH issue search index.
|
Test run using this pre-release version: https://github.com/pulumi/pulumi-xyz/actions/runs/11742090038/job/32712100051 Resulting PR has correct "fixes" directive: pulumi/pulumi-xyz#518 |
iwahbe
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be running very quickly after the issue was created and it might not yet be indexed. Instead, just list the latest 100 issues and filter on exact title format instead.
The current rate of issue creation is low enough that the latest 100 issues should safely include all open upgrade issues.
Fixes #291
We'll continue to use the token for issue de-duplication as this only happens once per day and so is reliably in the GH issue search index.