Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow scope of candidate issues using tags #294

Open
danielrbradley opened this issue Nov 8, 2024 · 0 comments
Open

Narrow scope of candidate issues using tags #294

danielrbradley opened this issue Nov 8, 2024 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@danielrbradley
Copy link
Member

danielrbradley commented Nov 8, 2024

When opening a pull request for a provider upgrade we need to find all issues it might close.

Previously, we filtered by author, but issues might be opened by different users to the PR if the tool is run locally.

We also add the hidden piece of text pulumiupgradeproviderissue within the body for searching. However, this takes a few seconds to be indexed after the issues is created resulting in issues not being linked to the PR.

Currently, we fetch the 100 latest open issues and check the titles client-side. If there's been more than 100 issues since an upgrade issue was opened, then it won't be included and auto-closed with the PR.

As an alternatively approach, we could allow a label to be specified to be added to all issues which we can also use for filtering the initial search. Our expectation is that label-based search should be immediately indexed and not delayed like the issue text and should therefore be more reliable.

See also:

@danielrbradley danielrbradley added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team and removed needs-triage Needs attention from the triage team labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

1 participant