Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The bridge does not accept secrets panic #2439

Closed
t0yv0 opened this issue Sep 24, 2024 · 16 comments
Closed

The bridge does not accept secrets panic #2439

t0yv0 opened this issue Sep 24, 2024 · 16 comments
Assignees
@guineveresaenger
Labels
impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed

Comments

@t0yv0
Copy link
Member

t0yv0 commented Sep 24, 2024

What happened?

After upgrading to the latest bridge, users encountered "The bridge does not accept secrets" panics.

Example

pulumi/pulumi-gcp#2405 is a good example where this was discovered.

Output of pulumi about

N/A

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team p1 A bug severe enough to be the next item assigned to an engineer impact/regression Something that used to work, but is now broken labels Sep 24, 2024
@t0yv0 t0yv0 mentioned this issue Sep 24, 2024
Open
@mjeffryes mjeffryes removed the needs-triage Needs attention from the triage team label Sep 24, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Sep 25, 2024

pulumi/pulumi-hcloud#603

@MehulKothari-Circuitry
Copy link

Facing similar issue with respect to deployment of my pulumi stack related to databricks.

panic: fatal: An assertion has failed: The bridge does not accept secrets, so we should not encounter them here
goroutine 33 [running]:
github.com/pulumi/pulumi/sdk/v3/go/common/util/contract.failfast(...

@VenelinMartinov
Copy link
Contributor

@MehulKothari-Circuitry, thanks for reporting. Which provider are you using?

@VenelinMartinov VenelinMartinov added the resolution/fixed This issue was fixed label Sep 25, 2024
@VenelinMartinov
Copy link
Contributor

Fixed in #2438

@MehulKothari-Circuitry
Copy link

@MehulKothari-Circuitry, thanks for reporting. Which provider are you using?

Hey @VenelinMartinov the provider is Databricks

@VenelinMartinov
Copy link
Contributor

Ok, thanks, I'll make a databricks release which should fix this!

@MehulKothari-Circuitry
Copy link

Ok, thanks, I'll make a databricks release which should fix this!
Did u update for databricks provider?
Hey @VenelinMartinov can you update for pulumi, pulumi-aws provider as well?

@MehulKothari-Circuitry
Copy link

Ok, thanks, I'll make a databricks release which should fix this!
Did u update for databricks provider?
Hey @VenelinMartinov can you update for pulumi, pulumi-aws provider as well?

@VenelinMartinov VenelinMartinov mentioned this issue Sep 25, 2024
Closed
@t0yv0 t0yv0 mentioned this issue Sep 25, 2024
Merged
pulumi-bot added a commit to pulumi/pulumi-aws that referenced this issue Sep 25, 2024
@pulumi-bot
Fix "the bridge does not accept secrets panic" by upgrade pulumi-terr…
93506d9 
…aform-bridge to v3.91.1 (#4526)

This change includes a fix for a regression in handling secrets in the
provider configuration properties
(pulumi/pulumi-terraform-bridge#2439) that
manifested as "the bridge does not accept secrets panic".

This PR was generated via `$ upgrade-provider pulumi/pulumi-aws
--kind=bridge --pr-reviewers=guineveresaenger`.

---

- Upgrading pulumi-terraform-bridge from v3.91.0 to v3.91.1.
- Upgrading pulumi-terraform-bridge/pf from v0.44.0 to v0.44.1.
@t0yv0
Copy link
Member Author

t0yv0 commented Sep 25, 2024

Releasing AWS here: pulumi/pulumi-aws#4526 (review) apologies for the disruption again.

@VenelinMartinov
Copy link
Contributor

Reopening until we resolve all provider issues

@Viperal Viperal mentioned this issue Sep 25, 2024
Merged
@guineveresaenger
Copy link
Contributor

GCP's was rolled into yesterday's upgrade.

Released patches of all remaining providers affected:

  • aiven
  • akamai
  • archive
  • artifactory
  • cloudflare
  • cloudinit
  • databricks
  • datadog
  • dbtcloud
  • dnsimple
  • ec
  • external
  • gitlab
  • hcloud
  • http
  • ise
  • junipermist
  • linode
  • local
  • meraki
  • mongodbatlas
  • null
  • okta
  • pagerduty
  • random
  • scm
  • sdwan
  • tls

iwahbe added a commit that referenced this issue Sep 26, 2024
@iwahbe
Add a test of Configure with secrets
9d4aa2b 
This test is borrowed from #2437. It
would have caught prevented #2439.
@iwahbe iwahbe mentioned this issue Sep 26, 2024
Merged
iwahbe added a commit that referenced this issue Sep 26, 2024
@iwahbe
Add a test of Configure with secrets (#2447)
65dd45d 
This test is borrowed from
#2437. These tests
would have prevented
#2439.
@sdibernardo
Copy link

I just pulled the latest versions and tried again, yet I still get the panic.

panic: fatal: An assertion has failed: The bridge does not accept secrets, so we should not encounter them here
goroutine 24 [running]:
github.com/pulumi/pulumi/sdk/v3/go/common/util/contract.failfast(...)
/home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/[email protected]/go/common/util/contract/failfast.go:23
github.com/pulumi/pulumi/sdk/v3/go/common/util/contract.Assertf(0xe0?, {0x1042078b2?, 0x140007b9230?}, {0x0?, 0x0?, 0x14000310080?})
/home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/[email protected]/go/common/util/contract/assert.go:35 +0xe0
github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfbridge.(*ConfigEncoding).UnfoldProperties(0x14000310080, 0x14000f54390)
/home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/[email protected]/pkg/tfbridge/config_encoding.go:143 +0x214
github.com/pulumi/pulumi-terraform-bridge/pf/internal/configencoding.(*provider[...]).ConfigureWithContext(0x14000e3b300, {0x104fbaba8?, 0x14000f54150}, 0x14000f54390)
/home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/[email protected]/internal/configencoding/provider.go:110 +0x4c
github.com/pulumi/pulumi-terraform-bridge/pf/internal/plugin.(*provider).Configure(0x104ad1a20?, {0x104fbaba8?, 0x14000f54150?}, {0x14000f1c7c0?})
/home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/[email protected]/internal/plugin/provider_context.go:143 +0x30
github.com/pulumi/pulumi-terraform-bridge/pf/internal/plugin.providerThunk.Configure({{0x104fe3e50?, 0x1400063aed0?}}, {0x104fbaba8, 0x14000f54150}, {0x0?})
/home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/[email protected]/internal/plugin/provider_server.go:83 +0x84
github.com/pulumi/pulumi/sdk/v3/go/common/resource/plugin.(*providerServer).Configure(0x14000dca030, {0x104fbaba8, 0x14000f54150}, 0x14000981100)
/home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/[email protected]/go/common/resource/plugin/provider_server.go:346 +0x2c4
github.com/pulumi/pulumi-terraform-bridge/pf/internal/plugin.(*providerServer).Configure(0x104f9b020?, {0x104fbaba8?, 0x14000f54150?}, 0x0?)
/home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/[email protected]/internal/plugin/provider_server.go:57 +0x30
github.com/pulumi/pulumi-terraform-bridge/x/muxer.(*muxer).Configure.func1()
/home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/x/[email protected]/muxer.go:298 +0x74
github.com/pulumi/pulumi-terraform-bridge/x/muxer.asyncJoin[...].func1()
/home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/x/[email protected]/muxer.go:595 +0x48
created by github.com/pulumi/pulumi-terraform-bridge/x/muxer.asyncJoin[...] in goroutine 22
/home/runner/go/pkg/mod/github.com/pulumi/pulumi-terraform-bridge/x/[email protected]/muxer.go:594 +0x78

My dependencies are:

Dependencies:
NAME VERSION
typescript 5.6.2
@pulumi/kubernetes 4.18.1
@pulumi/openstack 4.1.3
@pulumi/pulumi 3.134.1
@pulumi/random 4.16.6
@types/node 22.7.2
@ovhcloud/pulumi-ovh 0.50.0
@pulumi/aws 6.53.0
@pulumi/azure-native 2.63.0
rollup 4.22.4
tsup 8.3.0

I did a fresh clean + install but still I get this error and from the logs it seems that old versions are still used, e.g. v3.133.0 for the pulumi sdk.

Any advice on how to proceed?

Best regards
Sascha

@t0yv0
Copy link
Member Author

t0yv0 commented Sep 27, 2024

Do you know which provider is panic'ing Sascha, there should be some more context in the output compared to what you listed? We can double-check the release of that provider.

@sdibernardo
Copy link

Previewing update (dev):
Type Name Plan Info
pulumi:pulumi:Stack environment-dev 26 messages
└─ ovh:CloudProject:User dev-user 1 error

Diagnostics:
ovh:CloudProject:User (dev-user):
error: error reading from server: EOF

pulumi:pulumi:Stack (environment-dev):
(node:23091) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
(Use node --trace-deprecation ... to show where the warning was created)

panic: fatal: An assertion has failed: The bridge does not accept secrets, so we should not encounter them here

Seems to me like something with OVH Provider is broken, but I am not sure.
Happy to provide more info if needed 👍

iwahbe added a commit to iwahbe/pulumi-ovh that referenced this issue Sep 27, 2024
@iwahbe
Upgrade the bridge
9d25c93 
v3.91.0 contained a nasty bug:
pulumi/pulumi-terraform-bridge#2439 (comment). Upgrading
to v3.91.1 fixes the problem.
@iwahbe iwahbe mentioned this issue Sep 27, 2024
Merged
@iwahbe
Copy link
Member

iwahbe commented Sep 27, 2024

Hi @sdibernardo. pulumi-ovh is maintained by ovh, but I have opened a PR to fix the problem. Thanks for pointing this out.

@sdibernardo
Copy link

Thank you for taking action so quick 🥇

@scraly scraly mentioned this issue Sep 27, 2024
Closed
scraly pushed a commit to ovh/pulumi-ovh that referenced this issue Sep 27, 2024
@iwahbe
Upgrade the bridge (#233)
ab037f1 
v3.91.0 contained a nasty bug:
pulumi/pulumi-terraform-bridge#2439 (comment). Upgrading
to v3.91.1 fixes the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guineveresaenger guineveresaenger

Labels
impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@t0yv0 @mjeffryes @guineveresaenger @iwahbe @sdibernardo @VenelinMartinov @MehulKothari-Circuitry