Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking of executionRole in TaskDefinition #517

Merged
merged 2 commits into from
Mar 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ CHANGELOG
* Update `Service`, `EC2Service` and `FargateService` interface to support the full set of supported ECS Service properties
* Ensure `CustomResourceOptions` are passed to underlying `ecs.Service` when using `awsx.ecs.FargateService` and `awsx.ecs.EC2Service`
* Update `TaskDefinitionArgs`, `EC2TaskDefinitionArgs`, `FargateTaskDefinitionArgs` to allow for null taskRole, executionRole, and logGroup attributes.
* Fix bug in `TaskDefinition` when `executionRole` is ignored when `taskRole` is `null`.
[#517](https://github.com/pulumi/pulumi-awsx/pull/517)

## 0.19.2 (2020-01-31)

Expand Down
2 changes: 1 addition & 1 deletion nodejs/awsx/ecs/taskDefinition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export abstract class TaskDefinition extends pulumi.ComponentResource {
args.taskRole ? args.taskRole : TaskDefinition.createTaskRole(
`${name}-task`, /*assumeRolePolicy*/ undefined, /*policyArns*/ undefined, { parent: this });

this.executionRole = args.taskRole === null ? undefined :
this.executionRole = args.executionRole === null ? undefined :
args.executionRole ? args.executionRole : TaskDefinition.createExecutionRole(
`${name}-execution`, /*assumeRolePolicy*/ undefined, /*policyArns*/ undefined, { parent: this });

Expand Down