Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking of executionRole in TaskDefinition #517

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Fix checking of executionRole in TaskDefinition #517

merged 2 commits into from
Mar 4, 2020

Conversation

Igorbek
Copy link

@Igorbek Igorbek commented Mar 4, 2020

When taskRole is passed as null but executionRole is provided, TaskDefinition wrongly test another parameter and does not accept the execution role. This causes errors such as Fargate requires task definition to have execution role ARN to support ECR images..

leezen
leezen approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@leezen leezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@Igorbek
Copy link
Author

Igorbek commented Mar 4, 2020

/cc @stack72 @CyrusNajmabadi for review

@stack72 stack72 merged commit f5e9045 into pulumi:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leezen leezen leezen approved these changes

@stack72 stack72 stack72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Igorbek @stack72 @leezen