VCS refactoring almost completed + DB changes unified #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.2 to 2.8.3. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.8.2...2.8.3) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint](https://github.com/eslint/eslint) from 8.31.0 to 8.32.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.31.0...v8.32.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…_and_yarn/prettier-2.8.3 Bump prettier from 2.8.2 to 2.8.3
…_and_yarn/eslint-8.32.0 Bump eslint from 8.31.0 to 8.32.0
Add our Duplicate Versions Script
Bumps [superagent](https://github.com/ladjs/superagent) from 8.0.6 to 8.0.8. - [Release notes](https://github.com/ladjs/superagent/releases) - [Changelog](https://github.com/ladjs/superagent/blob/master/HISTORY.md) - [Commits](ladjs/superagent@v8.0.6...v8.0.8) --- updated-dependencies: - dependency-name: superagent dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…_and_yarn/superagent-8.0.8 Bump superagent from 8.0.6 to 8.0.8
Digitalone1
changed the title
Bumps [eslint](https://github.com/eslint/eslint) from 8.32.0 to 8.33.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.32.0...v8.33.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…pply-chain-attack Avoid names supply chain attack
…-system Prepare to migrate to the new versioning system
Upgrade Node Version
…-system-2 Prepare to migrate to the new versioning system - part 2
…_and_yarn/google-cloud/storage-6.9.1 Bump @google-cloud/storage from 6.9.0 to 6.9.1
…_and_yarn/superagent-8.0.9 Bump superagent from 8.0.8 to 8.0.9
…_and_yarn/jest-29.4.1 Bump jest from 29.4.0 to 29.4.1
…_and_yarn/eslint-8.33.0 Bump eslint from 8.32.0 to 8.33.0
Fixes in Production
10 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Filling out the template is required.
All new code requires tests to ensure against regressions.
Have you ran tests against this code?
Description of the Change
@confused-Techie please, take a look at this, tarball data appended to versions metadata objects were overwritten, so we need to clone the whole packageJSON.
Besided I added an util for metadata construction. This might seem overkill, but having the structure repeated in multiple places in the code is generally bad because you might update one and not the others when needed, while having a single point to serve it it's better because you modify the object in one place. You still need to update the function arguments, but maybe a default for additional arguments can be added in the future...
Update 2023/01/29
@confused-Techie Merged the DB changes branch with git refactoring branch and then fixed all the remaining issues. The tests are all passing! (except Codacy that seems not enabled for this branch)
There will be surely issues in production, but at least we have no issues on tests in developer mode.