improved insertNewPackageName

[Digitalone1]

Requirements

• Have you ran tests against this code?
• This PR contains zero code changes.

I got errors about express-rate-limit module not found.

Description of the Change

I gave a look at insertNewPackageName. I thought it may break uniqueness of packages.name inserting duplicate names into names. Only later I found out names.name is the primary key, so the new name should not be used to be inserted.

Anyway I added the code to update the name in the packages table (I suppose we want there the current name used, so the new name). And I wrapped the whole process into a transaction, which is useless if I made first the insertion in names and then exit on fail, but I wrongly supposed the names could be duplicated, so I made first the update into packages.

But the transaction is good anyway and also robust in case of unexpected errors, so I think it's acceptable as it is. Please give it a review.

Then I switched some variables to camel case notation.

[confused-Techie]

This overall looks fantastic!

Had me slightly concerned seeing the throw statements, but then realized you have everything wrapped with a catch, so smart move there, to help Failing Server Status Object Returns.

The tests look fine for what has been changed, but very hard to tell if this will change the functionality here as it's untested. But it looks great, and I'll just double check the SQL Syntax before commiting.

Thanks for the contribution!

[Digitalone1]

The throw will trigger the catch statement, which will trigger the rollback. ;)

Same done with other transactions.