This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
README: Add reminder to keep shell environment clean #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskurth
requested review from
alessandrocapotondi and
vogelpi
as code owners
| @@ -18,6 +18,8 @@ The HERO software development kit (SDK) contains the following submodules: | |||
| The HERO SDK currently supports the [Xilinx Zynq ZC706 Evaluation Kit](https://www.xilinx.com/products/boards-and-kits/ek-z7-zc706-g.html) as target hardware platform. | |||
|
|
|||
| ### Software | |||
| First, make sure your shell environment does not deviate from the system defaults regarding paths (`PATH`, `LD_LIBRARY_PATH`, etc) before setting up the SDK or sourcing the environment of the HERO SDK. | |||
There was a problem hiding this comment.
if I have to be honest, I think the disclaimer could be misleading. The root cause of the problem issued #40 is the fact that cmake version used was not compatible with our build flow. Then secondarily the problem was caused by the Vivado's environment that could change - in a stealth mode - the program versions compare the default ones.
There was a problem hiding this comment.
I see #40 as one specific instance of a more general workflow problem. A similar problem could have faced when a user sources the Vivado environment after sourcing the HERO environment, and the ARM compiler in the Vivado SDK is invoked instead of HERO's. So the very basic rule is: Non-default paths should be avoided.
alessandrocapotondi
approved these changes
Dec 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #40.