Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Fix #40. Added vivado's cmake troubleshooting #41

Merged
merged 3 commits into from
Dec 17, 2018
Merged

Fix #40. Added vivado's cmake troubleshooting #41

merged 3 commits into from
Dec 17, 2018

Conversation

alessandrocapotondi
Copy link
Contributor

No description provided.

@alessandrocapotondi alessandrocapotondi self-assigned this Dec 13, 2018
@andreaskurth
Copy link
Contributor

Regarding #40, I prefer #42. I think the Vivado problem is too specific to warrant a FAQ entry. What do you think?

@alessandrocapotondi
Copy link
Contributor Author

For me we could merge both the PRs since the Vivado environment can be consider as a specific use-case. But if you are against this solution we can keep you one.

@andreaskurth
Copy link
Contributor

Alright, let's keep both.

I took the liberty to add another commit to this branch to format the document, fix some typos, and remove whitespace errors

@alessandrocapotondi alessandrocapotondi merged commit 4612ea7 into master Dec 17, 2018
@alessandrocapotondi
Copy link
Contributor Author

@accuminium,
thanks!

@alessandrocapotondi alessandrocapotondi deleted the alessandrocapotondi-patch-1 branch December 17, 2018 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreaskurth andreaskurth andreaskurth approved these changes

@vogelpi vogelpi Awaiting requested review from vogelpi

Assignees

@alessandrocapotondi alessandrocapotondi

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessandrocapotondi @andreaskurth