Add omniauth gem #151
Add omniauth gem #151
Conversation
There was a problem hiding this comment.
I apologize, this is currently breaking for me in staging: https://orcid-staging.princeton.edu/sign_in. I can investigate Honeybadger to determine the source of the error.
Co-authored-by: James R. Griffin III <[email protected]>
Devise and OmniAuth routes for `session_path` and CAS authentication. Co-authored-by: Robert-Anthony Lee-Faison <[email protected]>
Co-authored-by: Robert-Anthony Lee-Faison <[email protected]>
There was a problem hiding this comment.
I have just tested this using a deployment on https://orcid-staging.princeton.edu, and I have confirmed that this is working for me.
There was a problem hiding this comment.
This seems to work. That said this solution on the wiki looks a bit more straight forward https://github.com/omniauth/omniauth/wiki/Upgrading-to-2.0#rails. It also seems like the solution in the PR will allow ANY token and that may not be great security wise. So @leefaisonr I'm not going to hit the big green button, but if you are done with this work feel free to. We could ticket trying to make it more secure... The other thing I saw on the internet was that the login link should be a post, which might be worth a try
No description provided.