Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating omniauth to not allow for old token to be passed #152

Closed
2 tasks
leefaisonr opened this issue Jun 4, 2024 · 2 comments · Fixed by #251
Closed
2 tasks

Updating omniauth to not allow for old token to be passed #152

leefaisonr opened this issue Jun 4, 2024 · 2 comments · Fixed by #251
Assignees

Comments

@leefaisonr
Copy link
Contributor

leefaisonr commented Jun 4, 2024

Expected Behavior

Only a CAS-authenticated user with a vaild CSRF token should be allow access into orcid staging and prod.

Current Behavior

Currently, a user with any CSRF token may be able to authenticate into orcid.

Implementation notes

These are links for potential refactors to the code that would add extra security for authentication into orcid for users through CAS.

See: #151 See line

Acceptance Criteria

@carolyncole carolyncole changed the title Updating omniauth to not allow for any token to be passed Updating omniauth to not allow for old token to be passed Jun 4, 2024
@leefaisonr
Copy link
Contributor Author

Possible solution: omniauth-rails_csrf_protection —> gem installation used to patch security holes for omniauth

@carolyncole
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants