Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore id to creating pub #680

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Restore id to creating pub #680

merged 1 commit into from
Oct 3, 2024

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Oct 2, 2024

Issue(s) Resolved

Quick follow up to #676 which replaced the create pub function, but neglected to keep the ability to specify a client side id (doh!)

High-level Explanation of PR

Needed for #657 to keep working properly

Test Plan

  • Create a field type of FileUpload
  • Add this field type to a pub type
  • Create a pub of this pub type and upload a file. In the network tab, you can inspect for what path this file is being uploaded to. Make a note of the pub Id
  • Submit the create pub form
  • The created pub's id should match the pub id that the file upload went up to (this is currently broken after Allow creating a pub without a stage #676!)

Screenshots (if applicable)

Notes

@allisonking allisonking marked this pull request as ready for review October 2, 2024 22:45
@3mcd 3mcd merged commit edc104a into main Oct 3, 2024
7 checks passed
@3mcd 3mcd deleted the aking/fix-create-pub-with-id branch October 3, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants