Allow creating a pub without a stage #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tefkah
reviewed
Oct 2, 2024
allisonking
commented
Oct 2, 2024
| id: pubId, | ||
| pubTypeId: pubTypeId as PubTypesId, | ||
| stageId: stageId as StagesId, | ||
| values: enabledPubValues as Record<string, any>, |
There was a problem hiding this comment.
I don't like the cast to any here, but I wasn't sure how to get these types to match up 😕
Type 'PubValues' is not assignable to type 'Record<string, Json>'.
'string' index signatures are incompatible.
Type 'JsonValue' is not assignable to type 'Json'.
Type 'JsonObject' is not assignable to type 'Json'.
Type 'JsonObject' is missing the following properties from type 'Json[]': length, pop, push, concat, and 35 more.ts(2322)
integrations.ts(97, 2): The expected type comes from property 'values' which is declared here on type 'CreatePubRequestBodyWithNullsNew | { id?: string | undefined; pubTypeId: string; parentId?: string | null | undefined; values: Record<string, Json>; assigneeId?: string | undefined; children?: (Omit<CreatePubRequestBodyWithNulls, "stageId"> & { stageId?: StagesId | undefined; })[] | undefined; stageId?: StagesId | undefined; }'
There was a problem hiding this comment.
I think this is fine for now! I've had trouble with the Json and JsonValue types before, too. At some point we can do a pass to improve the types for pub values objects across the project.
kalilsn
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Create a pub without a stage * Add tests * Reorder tests * Fix pub move tests * Use `createPubRecursiveNew` for creating pubs * Combine createpub actions * Handle the case of no values in the pub * Add test for creating a pub without values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Closes #557
High-level Explanation of PR
Allows the stage to be undefined on pub create. There's a new dropdown in the stage dropdown that is "No stage" which leads to an undefined stage.
The bulk of this change was actually using
createPubRecursiveNewinstead ofcreatePub.createPubRecursiveNewis used by the API and already takes an optional stage ID. I had to rejiggercreatePubRecursiveNewa little bit to allow for empty pub valuesTest Plan
Screenshots (if applicable)
Notes