Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromedriver brute force #8197

Closed
wants to merge 18 commits into from
Closed

chromedriver brute force #8197

wants to merge 18 commits into from

Conversation

cesswairimu
Copy link
Collaborator

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jul 28, 2020

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #8197 into main will decrease coverage by 1.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8197      +/-   ##
==========================================
- Coverage   81.69%   79.88%   -1.82%     
==========================================
  Files         100      100              
  Lines        5846     5866      +20     
==========================================
- Hits         4776     4686      -90     
- Misses       1070     1180     +110     
Impacted Files Coverage Δ
app/channels/application_cable/channel.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/application_cable/connection.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/user_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/channels/user_notification_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/channels/room_channel.rb 0.00% <0.00%> (-71.43%) ⬇️
app/controllers/subscription_controller.rb 59.59% <0.00%> (-11.12%) ⬇️
app/controllers/questions_controller.rb 81.57% <0.00%> (-9.22%) ⬇️
app/models/tag_selection.rb 88.00% <0.00%> (-8.00%) ⬇️
app/controllers/tag_controller.rb 76.14% <0.00%> (-5.20%) ⬇️
app/models/concerns/node_shared.rb 86.89% <0.00%> (-3.40%) ⬇️
... and 7 more

@jywarren
Copy link
Member

Cess you are not letting this one defeat you, huh?! 💪 🎉 ❤️

Thank you! And, don't exhaust yourself!

@cesswairimu
Copy link
Collaborator Author

Hi @alaxalves , no luck here yet...feel free to try the changes you were suggesting if you have some time.Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants