Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard SQLException and Travis system test fail #8186

Closed
wants to merge 30 commits into from

Conversation

keshavsethi
Copy link
Member

An error was coming in the dashboard and system tests were also failing.
Screenshot from 2020-07-24 19-06-48
I work fine after correcting the typo
Screenshot from 2020-07-24 19-08-47

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jul 24, 2020

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #8186 into main will decrease coverage by 1.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8186      +/-   ##
==========================================
- Coverage   81.69%   79.88%   -1.82%     
==========================================
  Files         100      100              
  Lines        5846     5866      +20     
==========================================
- Hits         4776     4686      -90     
- Misses       1070     1180     +110     
Impacted Files Coverage Δ
app/models/tag.rb 97.50% <100.00%> (ø)
app/channels/application_cable/channel.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/application_cable/connection.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/user_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/channels/user_notification_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/channels/room_channel.rb 0.00% <0.00%> (-71.43%) ⬇️
app/controllers/subscription_controller.rb 59.59% <0.00%> (-11.12%) ⬇️
app/controllers/questions_controller.rb 81.57% <0.00%> (-9.22%) ⬇️
app/models/tag_selection.rb 88.00% <0.00%> (-8.00%) ⬇️
app/controllers/tag_controller.rb 76.14% <0.00%> (-5.20%) ⬇️
... and 9 more

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jul 24, 2020

Just saw the system failures on travis on the recent PRs... Great job catching this @keshavsethi and opening this so quick 🎉 🎉 Thanks

@keshavsethi
Copy link
Member Author

Thanks!! @cesswairimu it is because of some chrome driver version.

Minitest::UnexpectedError:         Selenium::WebDriver::Error::SessionNotCreatedError: session not created: Chrome version must be between 70 and 73
          (Driver info: chromedriver=73.0.3683.68 (47787ec04b6e38e22703e856e101e840b65afe72),platform=Linux 4.15.0-1077-gcp x86_64)

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jul 24, 2020

Which is strange we haven't changed the version since February 🤔 not sure why we are getting the failures now...do we need to try 73.0.0?

@keshavsethi keshavsethi changed the title Dashboard SQLException Dashboard SQLException and Travis system test fail Jul 24, 2020
@keshavsethi
Copy link
Member Author

@cesswairimu @jywarren @alaxalves @icarito System Tests are failing because of the chrome driver version issue. Please check!!
Thanks!!

@cesswairimu
Copy link
Collaborator

From the latest travis-ci update notes it shows that Google Chrome changed to 83.0.4103.116-1..and the driver for this should be used with ChromeDriver 83.0.4103.39 or ChromeDriver 83.0.4103.14 but none of these seem to work 🤔 Not sure where we can get the exact chrome version that we are using

@keshavsethi
Copy link
Member Author

@cesswairimu @jywarren I tried a few things but still, errors are coming 🤔 Please check!!
Thanks!!

@cesswairimu
Copy link
Collaborator

I am going to try a brute-force from version 73 upwards see if anything works...opening on a new PR #8197

@jywarren
Copy link
Member

Oh gosh, this is pretty bad. Thanks for looking into this! I will check it out too to see if we can figure it out.

In the meantime, LOTS of info and guidance on Chromedriver here: #6095

@jywarren
Copy link
Member

This note refers to work by @alaxalves on this which helped us mitigate the chrome version moving target... perhaps related?

So the latest is that @alaxalves was able to pin to a 3rd party repository of Chrome versions, at https://github.com/webnicer/chrome-downloads, in #6099. It has Chrome 78, latest updated version 4 days ago, so this seems viable...

So we're pinned at Chrome 75 ChromeDriver 74:

@jywarren
Copy link
Member

jywarren commented Aug 5, 2020

Was this resolved? I see @cesswairimu closed this attempt: #8197

@jywarren
Copy link
Member

jywarren commented Aug 5, 2020

Ah i see finally in #8203 - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants