-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New sidebar design implementation for the notes show page #6005
Comments
Hi @jywarren Can we some explanation regarding the toggle buttons ? Like what does sub pages and other stuff means ? And what about the post option we have in sidebar right now ? Are we going to remove it ? |
HI @gautamig54 I added another checklist for adding tags in the page which is present we have in sidebar currently, and in a new one, its been done by small icon with plus button inside circle. |
Yes, let's remove the post option. People can post from the topic pages
themselves, or from their dashboard.
Some pages have sub-pages, like this --
https://publiclab.org/wiki/data-logging -- and we can just link to the same
listing as that page. Thanks!!!
…On Thu, Jul 11, 2019 at 2:50 AM Lekhika Dugtal ***@***.***> wrote:
Hi @jywarren <https://github.com/jywarren> Can we some explanation
regarding the toggle buttons ? Like what does sub pages and other stuff
means ? And what about the post option we have in sidebar right now ? Are
we going to remove it ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6005?email_source=notifications&email_token=AAAF6J4TZWYSJEAFLV4OHETP63JXXA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZVWDRI#issuecomment-510353861>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZBE6DTWRZMP55VB3TP63JXXANCNFSM4IAWLRMA>
.
|
Hi @jywarren Regarding edit and star buttons, They are related to notes/wikis and etc right ? |
And what about sharing in social media buttons , that we have currently present in sidebar ? Do we have to add this ? |
Star and edit are yes, for wikis and notes. Ah, good question! Yes, we'd
better put social in the same space at bottom of sidebar. Thanks!
…On Thu, Jul 11, 2019 at 2:24 PM Lekhika Dugtal ***@***.***> wrote:
And what about sharing in social media buttons , that we have currently
present in sidebar ? Do we have to add this ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6005?email_source=notifications&email_token=AAAF6J73YZE3RD4E33PJZ2LP653CXA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXSCSY#issuecomment-510599499>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZAP5SLZXINRIWBR2LP653CXANCNFSM4IAWLRMA>
.
|
Great !!!!
On Fri, Jul 12, 2019 at 12:01 AM Jeffrey Warren <[email protected]>
wrote:
… Star and edit are yes, for wikis and notes. Ah, good question! Yes, we'd
better put social in the same space at bottom of sidebar. Thanks!
On Thu, Jul 11, 2019 at 2:24 PM Lekhika Dugtal ***@***.***>
wrote:
> And what about sharing in social media buttons , that we have currently
> present in sidebar ? Do we have to add this ?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#6005?email_source=notifications&email_token=AAAF6J73YZE3RD4E33PJZ2LP653CXA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXSCSY#issuecomment-510599499
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAAF6JZAP5SLZXINRIWBR2LP653CXANCNFSM4IAWLRMA
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6005?email_source=notifications&email_token=AGLS6SSZE3VWYQUQTNVEZA3P654BTA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXSZ7Y#issuecomment-510602495>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGLS6SVHZDTC57J2EX7FJ7TP654BTANCNFSM4IAWLRMA>
.
|
HI @gautamig54, We dont have such icons with circle in font-awesome right ?
Does that mean I have to hardcode or this circle around the icon ?
…On Fri, Jul 12, 2019 at 12:03 AM lekhi dugtal ***@***.***> wrote:
Great !!!!
On Fri, Jul 12, 2019 at 12:01 AM Jeffrey Warren ***@***.***>
wrote:
> Star and edit are yes, for wikis and notes. Ah, good question! Yes, we'd
> better put social in the same space at bottom of sidebar. Thanks!
>
> On Thu, Jul 11, 2019 at 2:24 PM Lekhika Dugtal ***@***.***>
> wrote:
>
> > And what about sharing in social media buttons , that we have currently
> > present in sidebar ? Do we have to add this ?
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
> #6005?email_source=notifications&email_token=AAAF6J73YZE3RD4E33PJZ2LP653CXA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXSCSY#issuecomment-510599499
> >,
> > or mute the thread
> > <
> https://github.com/notifications/unsubscribe-auth/AAAF6JZAP5SLZXINRIWBR2LP653CXANCNFSM4IAWLRMA
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#6005?email_source=notifications&email_token=AGLS6SSZE3VWYQUQTNVEZA3P654BTA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXSZ7Y#issuecomment-510602495>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AGLS6SVHZDTC57J2EX7FJ7TP654BTANCNFSM4IAWLRMA>
> .
>
|
I think you may be able to use border-radius in css?
On Thu, Jul 11, 2019 at 2:44 PM Lekhika Dugtal <[email protected]>
wrote:
… HI @gautamig54, We dont have such icons with circle in font-awesome right ?
Does that mean I have to hardcode or this circle around the icon ?
On Fri, Jul 12, 2019 at 12:03 AM lekhi dugtal ***@***.***>
wrote:
> Great !!!!
>
> On Fri, Jul 12, 2019 at 12:01 AM Jeffrey Warren <
***@***.***>
> wrote:
>
>> Star and edit are yes, for wikis and notes. Ah, good question! Yes, we'd
>> better put social in the same space at bottom of sidebar. Thanks!
>>
>> On Thu, Jul 11, 2019 at 2:24 PM Lekhika Dugtal <
***@***.***>
>> wrote:
>>
>> > And what about sharing in social media buttons , that we have
currently
>> > present in sidebar ? Do we have to add this ?
>> >
>> > —
>> > You are receiving this because you were mentioned.
>> > Reply to this email directly, view it on GitHub
>> > <
>>
#6005?email_source=notifications&email_token=AAAF6J73YZE3RD4E33PJZ2LP653CXA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXSCSY#issuecomment-510599499
>> >,
>> > or mute the thread
>> > <
>>
https://github.com/notifications/unsubscribe-auth/AAAF6JZAP5SLZXINRIWBR2LP653CXANCNFSM4IAWLRMA
>> >
>> > .
>> >
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <
#6005?email_source=notifications&email_token=AGLS6SSZE3VWYQUQTNVEZA3P654BTA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXSZ7Y#issuecomment-510602495
>,
>> or mute the thread
>> <
https://github.com/notifications/unsubscribe-auth/AGLS6SVHZDTC57J2EX7FJ7TP654BTANCNFSM4IAWLRMA
>
>> .
>>
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6005?email_source=notifications&email_token=AAAF6J74I4QMHPW23ONOXUDP655QTA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXT34Q#issuecomment-510606834>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J7QWEIHR5FSOMCD5O3P655QTANCNFSM4IAWLRMA>
.
|
This idea is great !!!!!
Thanks Jeff.
On Fri, Jul 12, 2019 at 12:16 AM Jeffrey Warren <[email protected]>
wrote:
… I think you may be able to use border-radius in css?
On Thu, Jul 11, 2019 at 2:44 PM Lekhika Dugtal ***@***.***>
wrote:
> HI @gautamig54, We dont have such icons with circle in font-awesome
right ?
> Does that mean I have to hardcode or this circle around the icon ?
>
> On Fri, Jul 12, 2019 at 12:03 AM lekhi dugtal ***@***.***>
> wrote:
>
> > Great !!!!
> >
> > On Fri, Jul 12, 2019 at 12:01 AM Jeffrey Warren <
> ***@***.***>
> > wrote:
> >
> >> Star and edit are yes, for wikis and notes. Ah, good question! Yes,
we'd
> >> better put social in the same space at bottom of sidebar. Thanks!
> >>
> >> On Thu, Jul 11, 2019 at 2:24 PM Lekhika Dugtal <
> ***@***.***>
> >> wrote:
> >>
> >> > And what about sharing in social media buttons , that we have
> currently
> >> > present in sidebar ? Do we have to add this ?
> >> >
> >> > —
> >> > You are receiving this because you were mentioned.
> >> > Reply to this email directly, view it on GitHub
> >> > <
> >>
>
#6005?email_source=notifications&email_token=AAAF6J73YZE3RD4E33PJZ2LP653CXA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXSCSY#issuecomment-510599499
> >> >,
> >> > or mute the thread
> >> > <
> >>
>
https://github.com/notifications/unsubscribe-auth/AAAF6JZAP5SLZXINRIWBR2LP653CXANCNFSM4IAWLRMA
> >> >
> >> > .
> >> >
> >>
> >> —
> >> You are receiving this because you were mentioned.
> >> Reply to this email directly, view it on GitHub
> >> <
>
#6005?email_source=notifications&email_token=AGLS6SSZE3VWYQUQTNVEZA3P654BTA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXSZ7Y#issuecomment-510602495
> >,
> >> or mute the thread
> >> <
>
https://github.com/notifications/unsubscribe-auth/AGLS6SVHZDTC57J2EX7FJ7TP654BTANCNFSM4IAWLRMA
> >
> >> .
> >>
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#6005?email_source=notifications&email_token=AAAF6J74I4QMHPW23ONOXUDP655QTA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXT34Q#issuecomment-510606834
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAAF6J7QWEIHR5FSOMCD5O3P655QTANCNFSM4IAWLRMA
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6005?email_source=notifications&email_token=AGLS6SWCVKBOPQYJYXXLWUTP655YJA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXUB7Q#issuecomment-510607614>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGLS6SULGAGLTSUYMJ7QBWDP655YJANCNFSM4IAWLRMA>
.
|
Hi Jeff , could you look into this
#6001
…On Fri, Jul 12, 2019 at 12:18 AM lekhi dugtal ***@***.***> wrote:
This idea is great !!!!!
Thanks Jeff.
On Fri, Jul 12, 2019 at 12:16 AM Jeffrey Warren ***@***.***>
wrote:
> I think you may be able to use border-radius in css?
>
> On Thu, Jul 11, 2019 at 2:44 PM Lekhika Dugtal ***@***.***>
> wrote:
>
> > HI @gautamig54, We dont have such icons with circle in font-awesome
> right ?
> > Does that mean I have to hardcode or this circle around the icon ?
> >
> > On Fri, Jul 12, 2019 at 12:03 AM lekhi dugtal ***@***.***>
> > wrote:
> >
> > > Great !!!!
> > >
> > > On Fri, Jul 12, 2019 at 12:01 AM Jeffrey Warren <
> > ***@***.***>
> > > wrote:
> > >
> > >> Star and edit are yes, for wikis and notes. Ah, good question! Yes,
> we'd
> > >> better put social in the same space at bottom of sidebar. Thanks!
> > >>
> > >> On Thu, Jul 11, 2019 at 2:24 PM Lekhika Dugtal <
> > ***@***.***>
> > >> wrote:
> > >>
> > >> > And what about sharing in social media buttons , that we have
> > currently
> > >> > present in sidebar ? Do we have to add this ?
> > >> >
> > >> > —
> > >> > You are receiving this because you were mentioned.
> > >> > Reply to this email directly, view it on GitHub
> > >> > <
> > >>
> >
> #6005?email_source=notifications&email_token=AAAF6J73YZE3RD4E33PJZ2LP653CXA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXSCSY#issuecomment-510599499
> > >> >,
> > >> > or mute the thread
> > >> > <
> > >>
> >
> https://github.com/notifications/unsubscribe-auth/AAAF6JZAP5SLZXINRIWBR2LP653CXANCNFSM4IAWLRMA
> > >> >
> > >> > .
> > >> >
> > >>
> > >> —
> > >> You are receiving this because you were mentioned.
> > >> Reply to this email directly, view it on GitHub
> > >> <
> >
> #6005?email_source=notifications&email_token=AGLS6SSZE3VWYQUQTNVEZA3P654BTA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXSZ7Y#issuecomment-510602495
> > >,
> > >> or mute the thread
> > >> <
> >
> https://github.com/notifications/unsubscribe-auth/AGLS6SVHZDTC57J2EX7FJ7TP654BTANCNFSM4IAWLRMA
> > >
> > >> .
> > >>
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
> #6005?email_source=notifications&email_token=AAAF6J74I4QMHPW23ONOXUDP655QTA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXT34Q#issuecomment-510606834
> >,
> > or mute the thread
> > <
> https://github.com/notifications/unsubscribe-auth/AAAF6J7QWEIHR5FSOMCD5O3P655QTANCNFSM4IAWLRMA
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#6005?email_source=notifications&email_token=AGLS6SWCVKBOPQYJYXXLWUTP655YJA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXUB7Q#issuecomment-510607614>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AGLS6SULGAGLTSUYMJ7QBWDP655YJANCNFSM4IAWLRMA>
> .
>
|
Hi @gautamig54 Are you working on the tags cards portion ? Coz I can see that right now you have lots of issues in your bag ? |
Hi Gautami, Are you working on this ? |
Yes. I am working on it!
…On Mon, Jul 29, 2019, 15:05 Lekhika Dugtal ***@***.***> wrote:
Hi @gautamig54 <https://github.com/gautamig54> Are you working on the
tags cards portion ? Coz I can see that right now you have lots of issues
in your bag ?
Hi Gautami, Are you working on this ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6005?email_source=notifications&email_token=AINQWILHQAZAZWOSXNCSUZ3QB22WDA5CNFSM4IAWLRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3AFDXI#issuecomment-515920349>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AINQWIL33LW3DDUZYYO7UZTQB22WDANCNFSM4IAWLRMA>
.
|
Checklist :
cc : @CleverFool77 @jywarren
The text was updated successfully, but these errors were encountered: