Fix minify Module

[rishabhshuklax]

Fixes #1420

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[rishabhshuklax]

@publiclab/is-reviewers please review this.
Error was because of this

image-sequencer/src/modules/MinifyImage/Module.js

Line 52 in cded945

output(base64data, input.format);

image-sequencer/src/modules/MinifyImage/Module.js

Line 85 in cded945

function output(image, datauri, mimetype, wasmSuccess) {

[codecov]

Codecov Report

Merging #1512 into main will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             main   #1512      +/-   ##
=========================================
+ Coverage   66.79%   66.8%   +0.01%     
=========================================
  Files         129     129              
  Lines        2671    2672       +1     
  Branches      430     430              
=========================================
+ Hits         1784    1785       +1     
  Misses        887     887

Impacted Files	Coverage Δ
src/modules/PaintBucket/PaintBucket.js	100% <100%> (ø)	⬆️

[root00198]

The thing was that, this module is not minifying the image... If you compare input image and output image, they both are same.

[rishabhshuklax]

That's what this PR fixes.
The problem was caused by, I'm assuming #1365

[root00198]

#1422

Check this PR

[harshkhandeparkar]

Why doesn't this module use pixel manipulation?

[rishabhshuklax]

This uses compressorjs in browser environment for minifying image so we don't need to use pixel manipulation.

[harshkhandeparkar]

Can it minify GIFs?

[rishabhshuklax]

It doesnt use compressorjs in node env because our current code uses DOM elements like Blob, atob and even if we import them from jsdom the compressorjs uses Image() so it is throwing error in node that's why it is not using copressorjs in node but is using imagemin but I am getting this error, do you know anything about it @harshkhandeparkar

(node:26177) UnhandledPromiseRejectionWarning: Error: spawn /home/rs007/nodeJs/image-sequencer/node_modules/jpegtran-bin/vendor/jpegtran ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:19)
    at onErrorNT (internal/child_process.js:415:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)
(node:26177) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)

[harshkhandeparkar]

No, I have no idea about what that error means.

[rishabhshuklax]

Can it minify GIFs?

No, It just gives first frame as output image, i'm searching for an alternative
Do you have any idea?

[rishabhshuklax]

As of now it can just minimize jpg/jpeg/webp in browser

[harshkhandeparkar]

Do you have any idea?

Nope.

[rishabhshuklax]

Now this works in NodeJs too!

[jywarren]

Thank you! This is great!!!