-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCI] Added Lightning Bolt for WASM accelerated modules #1365
Conversation
Out of the 41 file changes, most are just repeated
|
Codecov Report
@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
- Coverage 66.23% 66.12% -0.12%
==========================================
Files 125 125
Lines 2559 2571 +12
Branches 400 404 +4
==========================================
+ Hits 1695 1700 +5
- Misses 864 871 +7
|
Hi! If wasm fails maybe we should show a red lightning icon? This is really nice. Is there anything we should think of that's changing documentation for module requirements that we should include in the readmes? Thanks! |
Also, I believe it needs a rebase! Thanks Harsh! |
@jywarren I'll do the rebase. I don't think the red bolt is required
because it is just a UI, red would be for debugging purposes. Users don't
care whether wasm worked or not. As for the debugging, it already logs an
error to the console. Also the code doesn't differentiate between `wasm
failed` and `wasm not used`.
I had checked the docs, I don't think we need to add anything. If we have
to, we will have to add a lot more. Many things like the
`pixelManipulation.js` are not fully documented. Maybe this can be a GCI
issue?
…On Thu, 19 Dec, 2019, 12:17 AM Jeffrey Warren, ***@***.***> wrote:
Also, I believe it needs a rebase! Thanks Harsh!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1365?email_source=notifications&email_token=AIJI5H3SG446T73XNEKDYB3QZJV3RA5CNFSM4J374LR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHHC63Q#issuecomment-567160686>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJI5HZCYF7EP2OA26LFGC3QZJV3RANCNFSM4J374LRQ>
.
|
@jywarren please try to merge this today. I want to claim the HoF task (about caching). I had done some work on it around 9 months back. I want to continue the work. Remember the PR for using package.json version for cache? |
Awesome!!!! |
Fixes #1320 (<=== Replace
0000
with the Issue Number)I think the issue asks to show an icon for modules that support WASM. But WASM can also fail. So I added an extra bit - Check if it succeeded or not and notify the UI. This makes it so that the icon is shown only if the WASM succeeds.
I also added a nice tooltip to the icon.
What works:
useWasm
flag is set totrue
, the module uses it and wasm succededWhat doesn't work:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!