update puppeteer for headless #1031
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1031 +/- ##
=======================================
Coverage 35.58% 35.58%
=======================================
Files 102 102
Lines 1942 1942
Branches 297 297
=======================================
Hits 691 691
Misses 1251 1251 |
…e-sequencer into headless-option-puppeteer
|
@jywarren also try adding the arg |
|
Oh this would be great to try. Thanks @VibhorCodecianGupta. I'm a bit occupied this week with our staff retreat meetings, but if someone else wants to try this please go for it! |
src/modules/_nomodule/gl-context.js
Outdated
| @@ -9,7 +9,7 @@ module.exports = function runInBrowserContext(input, callback, step, options) { | |||
|
|
|||
| var obj = { input: input, modOptions: minOptions } | |||
|
|
|||
| puppeteer.launch().then(function(browser) { | |||
| puppeteer.launch({headless: true, args:['--no-sandbox --disable-setuid-sandbox']}).then(function(browser) { | |||
There was a problem hiding this comment.
Tried a couple new things here. Maybe we should just merge this if it passes and then see if it works upstream? @VibhorCodecianGupta @harshkhandeparkar @Divy123 ?
There was a problem hiding this comment.
Sounds good. I'd test this but I do not have a GCF instance. image-sequencer-app is deployed on GCF, right @jywarren ?
There was a problem hiding this comment.
@jywarren I also do not have GCF instance. Any suggestions on testing it?
There was a problem hiding this comment.
We can test it on some cloud service like Google Cloud or firebase just to make sure it isn't broken
There was a problem hiding this comment.
Thanks, i just added @Divy123 and @VibhorCodecianGupta -- we're using this in Cloud Functions:
https://gist.github.com/jywarren/7721a38725affdbc4fad2598ff1be59e
@harshkhandeparkar i can add you too if you want to send me your email address.
Thanks!
There was a problem hiding this comment.
More info here: publiclab/image-sequencer-app#6
Thanks, all!
There was a problem hiding this comment.
@jywarren amazing, I'll try running it.
Also, I think issues #1030 #1033 #1029 are pretty urgent, I listed some possible fixes and your review is required there. Plugging in my proposal updates to your response as well (hope that's fine! :D) https://bit.ly/2VlDshL
Re karma-runner/karma-chrome-launcher#158 (comment) and publiclab/image-sequencer-app#6, trying this out!