Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification about JSON formats documentation #1029

Open
jywarren opened this issue Apr 19, 2019 · 3 comments
Open

Clarification about JSON formats documentation #1029

jywarren opened this issue Apr 19, 2019 · 3 comments
Assignees

Comments

@jywarren
Copy link
Member

Hi @VibhorCodecianGupta just wondering about these two sections in the readme and any ambiguities about them:

https://github.com/publiclab/image-sequencer/blob/main/README.md#adding-steps-to-the-image

mentions using JSON and offers an example. And i was wondering how to pass in options in the JSON format, so perhaps another example of that would be great (even including a function for a module that accepts that, like blend?)

But then this section lower down references JSON format too, but it seems more complex:

https://github.com/publiclab/image-sequencer/blob/main/README.md#importing-steps-using-json-array

Any thoughts on these? Thanks and sorry i'm just trying to read this as a newcomer might. Thank you!

@jywarren jywarren changed the title Clarification about JSON formats Clarification about JSON formats documentation Apr 19, 2019
@vibhorgupta-gh
Copy link

vibhorgupta-gh commented Apr 20, 2019

@jywarren you're right, maybe we can document this better.

I mentioned here that IS supports string syntax and JSON. The syntax sequencer.addSteps('brightness{brightness:80}') is actually closer to a stringified JSON. Perhaps we can specify that the new support allows for string syntax which includes stringified JSON? This is because JSON is already supported here in raw form, and docs seem redundant this way. Thoughts?

@jywarren
Copy link
Member Author

I guess perhaps we should think about running /everything/ through the same auto-identifier of syntax, and not having different ways JSON works. The string syntax is, indeed, intended to be similar to simplified JSON, but we skipped : and , to make it more compact in URLs.

I think the main thing is we should provide more full examples of the JSON that's accepted. Then we can look at where and if they differ, and how we could consolidate and standardize it. What do you think?

@vibhorgupta-gh vibhorgupta-gh self-assigned this Apr 25, 2019
@vibhorgupta-gh
Copy link

@jywarren agreed. So this is first a documentation issue and then perhaps a refactoring issue if need be. I'll get on to it in some time, have been caught up due to my exams coming up 😅 I also made some suggestions to your concerns in my proposal, if you could have a look here
https://publiclab.org/notes/vibhordelgupta/04-09-2019/soc-proposal-image-sequencer-broadening-avenues?_=1555858027

@jywarren jywarren added this to the Core improvements milestone May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants