-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo where steps can be set via URL hash #91
Comments
So, for example, if someone says "I wish there were a fast way to crop and threshold these images", you could send them a link to the demo with the right steps configured, and they'd go and it'd be all set up for them, with no having to change the demo code :-) |
Yes, I agree to this. I shall do that. Now working on #82 :-) |
awesome! |
This will be great. I think we can even embed a customized sequencer into a wiki page or research note on PublicLab.org -- it'll be a great way to put the library into use! |
Hope to do that soon :-) |
The demo is pretty much done for now, so I shall start working on this |
Great. Sorry for being offline much of this week, it was a vacation I really needed! I'll be back online this coming week. |
What if the user wants to set any options? I think that should be included in the hash as well. |
Sure, but then the hash may get pretty long. Let's see how it does though.
Maybe we can either offer to save the options with a checkbox or we can
just clearly label options so they can be cut out of the URL if people
want. But yes let's start by including them. Good idea!
…On Aug 20, 2017 8:54 AM, "Chinmay Pandhare" ***@***.***> wrote:
What if the user wants to set any options? I think that should be included
in the hash as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ66kIJ04v-uFzclU3S13n_inwv09ks5saCxxgaJpZM4Ozae7>
.
|
should we add a distinct button called "generate permalink" to this? Or is it clear? |
This is pretty clear. Yes, we should start including them. |
What do you think about a syntax more like:
|
also I added you on npmjs.org - you should be able to |
Now that I think of it, let's just break this in two. First version should have just steps, no options. It'll just use the defaults. Let's open another issue (which we can think about a bit longer) that has options presets too. That more extended version shouldn't stop us from doing the initial version first. |
Looks cool. Will do! |
Completed and split off new issue! |
So it looks in
window.location.hash
to find a comma delimited set of steps, like#steps=ndvi,threshold
, and adds them to the reconfigurable demo.As you remove/add steps, we update the URL hash to reflect this.
That way, we can pass around almost any imaginable demo sequencer as a fixed URL -- very useful!
This would come after #82 (completed!). Some example of reading/writing the URL hash can be found at https://github.com/jywarren/fisheyegl/blob/master/example/urlHash.js
The text was updated successfully, but these errors were encountered: