Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get settings updates in demo to only run() from current index #286

Closed
jywarren opened this issue Jun 8, 2018 · 18 comments
Closed

get settings updates in demo to only run() from current index #286

jywarren opened this issue Jun 8, 2018 · 18 comments

Comments

@jywarren
Copy link
Member

jywarren commented Jun 8, 2018

Using the new version of Run!

@jywarren
Copy link
Member Author

jywarren commented Jun 8, 2018

Actually I realized the new Run is a major version update because we've broken the previous version of Run. Can you also bump a major version?

@gitmate
Copy link

gitmate bot commented Jun 8, 2018

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are #130 (get CLI to run synchronously for chainability), #261 (Set of smaller issues for Run() and AddStep/InsertStep), #91 (Demo where steps can be set via URL hash), and #140 (Make demo display corresponding commandline syntax for current sequence).

1 similar comment
@gitmate
Copy link

gitmate bot commented Jun 8, 2018

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are #130 (get CLI to run synchronously for chainability), #261 (Set of smaller issues for Run() and AddStep/InsertStep), #91 (Demo where steps can be set via URL hash), and #140 (Make demo display corresponding commandline syntax for current sequence).

@tech4GT
Copy link
Member

tech4GT commented Jun 8, 2018

@jywarren I think I did this in it too!! I did update the demo to run from current index on save and addstep, run from 0 when page is visited!!

@tech4GT
Copy link
Member

tech4GT commented Jun 8, 2018

bumping major version though!!

@tech4GT
Copy link
Member

tech4GT commented Jun 8, 2018

@jywarren Also can we putout a tweet about the sequencer 2.0 this is so exciting!!!!!

@jywarren
Copy link
Member Author

jywarren commented Jun 8, 2018 via email

@tech4GT
Copy link
Member

tech4GT commented Jun 8, 2018

Awesome!! Closing this via #287

@tech4GT tech4GT closed this as completed Jun 8, 2018
@jywarren jywarren mentioned this issue Jun 8, 2018
@tech4GT tech4GT reopened this Jun 8, 2018
@tech4GT
Copy link
Member

tech4GT commented Jun 8, 2018

@jywarren what issues are you facing specifically??

@jywarren
Copy link
Member Author

jywarren commented Jun 8, 2018 via email

@tech4GT
Copy link
Member

tech4GT commented Jun 8, 2018

@jywarren hmm this wierd, I just tried it and It worked

@tech4GT
Copy link
Member

tech4GT commented Jun 8, 2018

@jywarren are we serving the right files??

@jywarren
Copy link
Member Author

jywarren commented Jun 8, 2018 via email

@jywarren
Copy link
Member Author

jywarren commented Jun 8, 2018 via email

@tech4GT
Copy link
Member

tech4GT commented Jun 8, 2018

@jywarren looking into this now!!

@tech4GT
Copy link
Member

tech4GT commented Jun 8, 2018

Ah small error!! found it!!

@tech4GT
Copy link
Member

tech4GT commented Jun 8, 2018

@jywarren should we now publish to npm??

@jywarren
Copy link
Member Author

jywarren commented Jun 8, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants