-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get settings updates in demo to only run() from current index #286
Comments
Actually I realized the new Run is a major version update because we've broken the previous version of Run. Can you also bump a major version? |
GitMate.io thinks the contributor most likely able to help you is @ccpandhare. Possibly related issues are #130 (get CLI to run synchronously for chainability), #261 (Set of smaller issues for Run() and AddStep/InsertStep), #91 (Demo where steps can be set via URL hash), and #140 (Make demo display corresponding commandline syntax for current sequence). |
1 similar comment
GitMate.io thinks the contributor most likely able to help you is @ccpandhare. Possibly related issues are #130 (get CLI to run synchronously for chainability), #261 (Set of smaller issues for Run() and AddStep/InsertStep), #91 (Demo where steps can be set via URL hash), and #140 (Make demo display corresponding commandline syntax for current sequence). |
@jywarren I think I did this in it too!! I did update the demo to run from current index on save and addstep, run from 0 when page is visited!! |
bumping major version though!! |
@jywarren Also can we putout a tweet about the sequencer 2.0 this is so exciting!!!!! |
:-)))
…On Fri, Jun 8, 2018, 2:19 PM Varun Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> Also can we putout a tweet about
the sequencer 2.0 this is so exciting!!!!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#286 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJzHME-4RRBmGuNnQ3-Kk4kyT1IPuks5t6sAHgaJpZM4Ugvd7>
.
|
Awesome!! Closing this via #287 |
@jywarren what issues are you facing specifically?? |
I added a set of 3 invert operations, and when i delete the middle one, the
last one doesn't re-run. I think we should be able to write a test for this
sort of thing... but for now, manually testing it showed some
inconsistencies like this.
…On Fri, Jun 8, 2018 at 2:43 PM, Varun Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> what issues are you facing
specifically??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#286 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ31oXpRBWtyl9Q6AFwg5OQIWCh9xks5t6sXOgaJpZM4Ugvd7>
.
|
@jywarren hmm this wierd, I just tried it and It worked |
@jywarren are we serving the right files?? |
Try opening this locally and then deleting the `invert` step:
http://localhost:8000/examples/#steps=import-image(url:%2Fexamples%2Fimages%2Fmonarch.png),saturation(saturation:0.5),channel(channel:green),invert()
…On Fri, Jun 8, 2018 at 2:49 PM, Varun Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> hmm this wierd, I just tried it
and It worked
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#286 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJxJfkpzrqxl5v70VC6JEZsvxRllBks5t6sdGgaJpZM4Ugvd7>
.
|
ER wait! Deleting the "channel" step i mean! The Invert step is then
unaffected for me?
…On Fri, Jun 8, 2018 at 2:56 PM, Jeffrey Warren ***@***.***> wrote:
Try opening this locally and then deleting the `invert` step:
http://localhost:8000/examples/#steps=import-image(
url:%2Fexamples%2Fimages%2Fmonarch.png),saturation(
saturation:0.5),channel(channel:green),invert()
On Fri, Jun 8, 2018 at 2:49 PM, Varun Gupta ***@***.***>
wrote:
> @jywarren <https://github.com/jywarren> hmm this wierd, I just tried it
> and It worked
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#286 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AABfJxJfkpzrqxl5v70VC6JEZsvxRllBks5t6sdGgaJpZM4Ugvd7>
> .
>
|
@jywarren looking into this now!! |
Ah small error!! found it!! |
@jywarren should we now publish to npm?? |
I already did!!!
…On Fri, Jun 8, 2018 at 3:48 PM, Varun Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> should we now publish to npm??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#286 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ995sIPTirTFsYTswSfD0xWJhuMfks5t6tT5gaJpZM4Ugvd7>
.
|
Using the new version of Run!
The text was updated successfully, but these errors were encountered: