Displayed url of image origin, in MapKnitter Lite interface

[7malikk]

Fixes #1153

Screenshot

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updates
• @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[welcome]

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

[gitpod-io]

[7malikk]

@jywarren @TildaDares @cesswairimu Hello, kindly review my PR, it fixes 1153
Thank you.

[jywarren]

Great start here!

[7malikk]

@jywarren Hello, i have added a screenshot and excluded the code editor formatting

[7malikk]

Hello, @TildaDares,could you review my PR

[7malikk]

@TildaDares kindly review my PR

[7malikk]

Hello @jywarren could you review my PR, thank you!

[7malikk]

@jywarren I've removed the spaces and new lines, kindly review.
Thanks a bunch

[jywarren]

Looking good - i still see changes from ' to " - can you revert those too? Basically in this view, it's very helpful to see ONLY the changes relevant to the issue: https://github.com/publiclab/Leaflet.DistortableImage/pull/1154/files

[7malikk]

Alright, @jywarren inlcuded your impeccable suggestion. Ready for a review and merge

[7malikk]

@jywarren, You must be tired of my pings but I promise this is the last one 😆

[jywarren]

Haha no worries! Actually there are still a few unrelated formatting differences in https://github.com/publiclab/Leaflet.DistortableImage/pull/1154/files - we really appreciate if your changes are ONLY those relevant to the feature in this PR. Sorry to keep asking for more changes!

[7malikk]

Oh, okay, I'd get right on that @jywarren 😁

[7malikk]

@jywarren final one i promise 🤣

[jywarren]

Hi, I just reverted all the changes in the dist folder, because you didn't change anything in /src/ so there shouldn't be anything compiled in /dist/ -- probably it had auto-built and got some slight version differences in your dependencies, but we should be fine now! Will merge as soon as the test passes, great work!

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

[jywarren]

🎉

[jywarren]

great job!!!

…

On Sun, Oct 16, 2022 at 2:27 PM welcome[bot] ***@***.***> wrote: Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to https://mapknitter.org in the next few days. Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page <https://code.publiclab.org#r=all> (where you'll now be featured as a recent contributor!). Thanks! *Help others take their first step* Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 https://code.publiclab.org <https://code.publiclab.org#r=all> Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here <publiclab/plots2#3458>, or find other ways to offer mutual support here <https://github.com/publiclab/plots2/labels/support>. — Reply to this email directly, view it on GitHub <#1154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J2JSCQA54P2BXXWGRLWDRCHNANCNFSM6AAAAAAREZIHVE> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[7malikk]

Thank you so much @jywarren
It's been a long time coming😁
More to come by the way😌