-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display url where images came from, in MapKnitter Lite interface #1153
Comments
@jywarren i'd like to claim this issue, i have done my FTO |
Ok @7malikk how would you approach this? Thank you! |
@jywarren I would create an What do you think? |
Sounds good, would you like to open a PR? |
Yes, I would, I'll get on it right away |
id like to try this |
Maybe you could even just modify line 120? |
@jywarren thank you, ill work on it |
Hi @THEDARKMAN007 it looks like @7malikk has already begun here. Maybe you could look over the PR and offer any suggestions, or we can try finding another task for you soon? |
@jywarren I would like to go over the PR or if there is another task i would like to do that |
Resolved in #1154. Thanks all! |
When using MapKnitter Lite at https://publiclab.github.io/Leaflet.DistortableImage/examples/archive, when images begin to load, we could show a sentence about where they were loaded from (just displaying the URL which was input in the previous step):
We could insert a line outside this block, or possibly before it:
Leaflet.DistortableImage/examples/archive.html
Lines 116 to 123 in 6e426d8
input.value
is the URL that was input. We can create a<p>
tag and say "images fetched from LINK" where LINK is the URL. Even better, it could be a link itself!Would someone who's done a first timers only issue already like to take this up?
The text was updated successfully, but these errors were encountered: