Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display url where images came from, in MapKnitter Lite interface #1153

Closed
jywarren opened this issue Oct 13, 2022 · 12 comments
Closed

Display url where images came from, in MapKnitter Lite interface #1153

jywarren opened this issue Oct 13, 2022 · 12 comments

Comments

@jywarren
Copy link
Member

When using MapKnitter Lite at https://publiclab.github.io/Leaflet.DistortableImage/examples/archive, when images begin to load, we could show a sentence about where they were loaded from (just displaying the URL which was input in the previous step):

Screenshot_20221014-081354

We could insert a line outside this block, or possibly before it:

imageContainer.appendChild(imageRow);
imageCount++;
}
});
responseText.innerHTML = imageCount ? `${imageCount} image(s) fetched successfully.` : 'No images found in the link provided...'
} else {
responseText.innerHTML = 'No images found in the link provided...'
}

input.value is the URL that was input. We can create a <p> tag and say "images fetched from LINK" where LINK is the URL. Even better, it could be a link itself!

Would someone who's done a first timers only issue already like to take this up?

@7malikk
Copy link
Collaborator

7malikk commented Oct 13, 2022

@jywarren i'd like to claim this issue, i have done my FTO

@jywarren
Copy link
Member Author

Ok @7malikk how would you approach this? Thank you!

@7malikk
Copy link
Collaborator

7malikk commented Oct 13, 2022

@jywarren I would create an <p> tag with the text like you stated 'Images fetched from here' where "here" would be wrapped in an <a> tag with href=input.value before the code block.

What do you think?

@jywarren
Copy link
Member Author

Sounds good, would you like to open a PR?

@7malikk
Copy link
Collaborator

7malikk commented Oct 13, 2022

Sounds good, would you like to open a PR?

Yes, I would, I'll get on it right away

@abd123codes
Copy link
Contributor

id like to try this

@jywarren
Copy link
Member Author

Maybe you could even just modify line 120?

@abd123codes
Copy link
Contributor

@jywarren thank you, ill work on it

@jywarren
Copy link
Member Author

Hi @THEDARKMAN007 it looks like @7malikk has already begun here. Maybe you could look over the PR and offer any suggestions, or we can try finding another task for you soon?

@Tammy-Ajoko
Copy link
Contributor

@jywarren I would like to go over the PR or if there is another task i would like to do that

@7malikk
Copy link
Collaborator

7malikk commented Oct 16, 2022

Hello @jywarren We can close this issue as we already resolved it in #1154

@TildaDares
Copy link
Member

Resolved in #1154. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants