-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with upstream React Native 0.44.0 #163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ptmt
commented
May 13, 2017
•
edited
Loading
edited
- Unit tests passing
- e2e tests passing
- Publish to npm as alpha
- UIExample works as expected
- Publish to npm as release
Reviewed By: kittens Differential Revision: D4897832 fbshipit-source-id: ff3215b45de389b91825371a987314e4bab5421f
Reviewed By: zertosh Differential Revision: D4893660 fbshipit-source-id: ed85f5d4c585164d464a7e009888a28e5af339cd
Reviewed By: achen1 Differential Revision: D4883119 fbshipit-source-id: 1adb57f333742fca9c5e1ece6355ee18881c48a4
Reviewed By: AaaChiuuu Differential Revision: D4873849 fbshipit-source-id: b5235b952faea2e42fb4292fac4ca409e22ecb56
Reviewed By: achen1 Differential Revision: D4890251 fbshipit-source-id: 3945c0e85fba15d588aa3b5760c64c5d81c6c516
…as filtered Summary: **Bug Description** The FlatList component receives content items via the data prop, and renders an initial number of items on the app's view. When a user scrolls to the end of the list, the component will append and render more available items at the end of the list. There was a bug where when the content was filtered, there were more available items but the component did not append/render them. This is due to the current appending/rendering logic in VirtualizedList, which does not account for data changes as a condition for updating/rendering. VirtualizedList is a dependency of FlatList, so this issue affects FlatList as well. **Approach to Fixing Bug** (i) Reproduce bug on iOS view of FlatList. (ii) For VirtualizedList component: # Isolate onEndReached function that appends more data to component UI. # Isolate _onContentSizeChange function that is called when list content changes. # Write snapshot tests using jest, based off existing test for FlatList. # Refactor logic to append more data to list into _maybeCallOnEndReached function. # Call _maybeCallOnEndReached in both _onContentSizeChange and _onScroll. (iii) Run snapshot tests and observe jest output. (iv) Bring up iOS view of FlatList and check that component now renders more items when content is filtered. Many thanks to sahrens for guidance in developing this code! Reviewed By: sahrens Differential Revision: D4877388 fbshipit-source-id: c10c9eef1912f491450a62b81a9bc41f7f784203
Reviewed By: achen1 Differential Revision: D4883219 fbshipit-source-id: 45671a6d51357fd51ca824a59f7b200c3df66b89
Reviewed By: achen1 Differential Revision: D4890541 fbshipit-source-id: 7fc87d3341a1cefd474481dcc1b7b6d02d92f445
Reviewed By: AaaChiuuu Differential Revision: D4883331 fbshipit-source-id: c901051d0aa5993142104126bbec5d76bd605e0b
Summary: Motivation: When viewing a stack trace in YellowBox where one or more of the stack frames has no `file`, JS will encounter the fatal error `null is not an object (evaluating 'file.split')`. This can happen, for example, when running a bundle for which no source maps were generated. Closes facebook/react-native#13512 Differential Revision: D4896480 Pulled By: javache fbshipit-source-id: 202c793a47abb83a4700a5778a92b0b5828b01a3
Summary: It seems we don't need that one much anymore, as we have a FS-based cache for files, and removing the last callsites doesn't really change perf, as we have to read these files eventually (plus some of these are read from `HasteMap`, that I believe is already dead code). Reviewed By: davidaurelio Differential Revision: D4884220 fbshipit-source-id: 4cf59f16a6f0bdf275abe81e9de2f34816866bae
Reviewed By: davidaurelio Differential Revision: D4884343 fbshipit-source-id: ae29757690d9b56d6f166bc86573aca9b1b6b65c
Reviewed By: davidaurelio Differential Revision: D4868312 fbshipit-source-id: 44d20a5ed73637a9b3f43a99b5c82931f3e15dc6
Reviewed By: cpojer Differential Revision: D4906382 fbshipit-source-id: 1696c3e7fe07c84a3a497740dc87a237d9b71d1e
Summary: There's something wrong with the Linux binary in Flow v0.44.1. It doesn't work. Flow v0.44.2 fixes, however CircleCI may have cached Flow v0.44.1. Putting this PR up in case it's needed. yarn install yarn run flow Closes facebook/react-native#13549 Differential Revision: D4902838 Pulled By: gabelevi fbshipit-source-id: 7f5223f7447dc0387955a94a0945915521a508c4
Summary: Changes the contract for `getTransformOptions` so that it has to return a promises. That allows call sites to get rid of special logic / wrapping. Reviewed By: jeanlauliac Differential Revision: D4905959 fbshipit-source-id: c7d434c0766984e25987de1d769594e7c922d691
Reviewed By: javache Differential Revision: D4889427 fbshipit-source-id: 1f74416b858134ec3682b1302021131114763881
Summary: removed duplicate colors Thanks for submitting a PR! Please read these instructions carefully: - [ ] Explain the **motivation** for making this change. - [ ] Provide a **test plan** demonstrating that the code is solid. - [ ] Match the **code formatting** of the rest of the codebase. - [ ] Target the `master` branch, NOT a "stable" branch. What existing problem does the pull request solve? A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. If you have added code that should be tested, add tests. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests a Closes facebook/react-native#13555 Differential Revision: D4908510 Pulled By: javache fbshipit-source-id: 819a3c2788232bc092cccc071f115853e7caddad
Summary: It's recommended to remove units for all zero length values because these units aren't being used and therefore can be safely removed to save bytes. Closes facebook/react-native#13518 Differential Revision: D4905286 Pulled By: javache fbshipit-source-id: 4119eb8034b4b5b864228316c5a450978d4328e9
Summary: Output the reason for the error when failing to load source code. This was a big help when trying to diagnose facebook/react-native#13299. ~~Unfortunately there still seems to be no way to get the offending line number (because `loadError.userInfo[RCTJSStackTraceKey]` is empty), but this is good enough.~~ Before: ``` [warn][tid:com.facebook.react.JavaScript][RCTBatchedBridge.m:510] Failed to execute source code. Unhandled JS Exception: SyntaxError ``` After: ``` [warn][tid:com.facebook.react.JavaScript][RCTJSCErrorHandling.mm:30] Couldn't get stack trace for http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:81886 [warn][tid:com.facebook.react.JavaScript][RCTBatchedBridge.m:510] Failed to execute source code. Unhandled JS Exception: SyntaxError Unexpected keyword 'var' ``` Closes facebook/react-native#13561 Differential Revision: D4908501 Pulled By: javache fbshipit-source-id: a316dc70739b917b3cc690309d0ff37a8bb5d412
Summary: Thanks for submitting a PR! Please read these instructions carefully: - [ ] Explain the **motivation** for making this change. - [ ] Provide a **test plan** demonstrating that the code is solid. - [ ] Match the **code formatting** of the rest of the codebase. - [ ] Target the `master` branch, NOT a "stable" branch. What existing problem does the pull request solve? A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. If you have added code that should be tested, add tests. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged. Closes facebook/react-native#13556 Differential Revision: D4908506 Pulled By: javache fbshipit-source-id: 17f6a57e31e68dc79ac9b5303bf56461663d7edd
Reviewed By: yfeldblum Differential Revision: D4711054 fbshipit-source-id: 00897ca703f0f3a8cddaf170fef53f9851b631af
Summary: Immutable doesn't seem to be used in react-native anymore so I've removed it as a dependency. Ensure that all tests pass. Closes facebook/react-native#13471 Differential Revision: D4877659 Pulled By: javache fbshipit-source-id: f06996d6d0af73e5bd0108cec75370eec66ca038
Summary: Thanks for submitting a PR! Please read these instructions carefully: - [ ] Explain the **motivation** for making this change. - [ ] Provide a **test plan** demonstrating that the code is solid. - [ ] Match the **code formatting** of the rest of the codebase. - [ ] Target the `master` branch, NOT a "stable" branch. When copy pasting the SectionList, got an error with a non closing JSX tag What existing problem does the pull request solve? Closing the JSX tag in 2 files no test required A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. If you have added code that should be tested, add tests. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Closes facebook/react-native#13525 Differential Revision: D4908495 Pulled By: javache fbshipit-source-id: f2dc49c9238d1da8906f7daf144429a57ad725a3
Reviewed By: bvaughn Differential Revision: D4905062 fbshipit-source-id: 43c24e7bcaf06eb4c7385b7022d0f20cf42d6f2f
Reviewed By: achen1 Differential Revision: D4908279 fbshipit-source-id: 8de9930a2160f3201f8b7a8a66415310fa2f41de
Reviewed By: achen1 Differential Revision: D4900998 fbshipit-source-id: af2283525b4e9856d7ff3466096226c4c1209f6b
Summary: facebook/react-native#13478 (comment) Fix incorrect usage of `url` in the `source` property of `<Image />` in the example. Closes facebook/react-native#13496 Differential Revision: D4893299 Pulled By: hramos fbshipit-source-id: 134f9100d16997627b14c145256818e05017bbe3
Summary: Issue Fix: #13485 Yet another race condition that was found by XCode's Thread Sanitizer. Happens because wasBatchActive is read/write from multiple threads at the same time - opened UIExplorer and see it works - npm run test pass - tested on own project as well Signed CLA Closes facebook/react-native#13505 Differential Revision: D4906096 Pulled By: javache fbshipit-source-id: 5d4329aafcfe9491ce0188fa1e2dd71e09b31031
Summary: Closes facebook/react-native#13449 Differential Revision: D4895880 Pulled By: hramos fbshipit-source-id: 12b0462131208d525df8725d981d3e9039c53472
to be on pair with upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.