Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uri instead of url in source property of Image #13496

Closed
wants to merge 1 commit into from
Closed

Use uri instead of url in source property of Image #13496

wants to merge 1 commit into from

Conversation

mehcode
Copy link
Contributor

@mehcode mehcode commented Apr 13, 2017

#13478 (comment)

Fix incorrect usage of url in the source property of <Image /> in the example.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Apr 13, 2017
@mehcode mehcode mentioned this pull request Apr 13, 2017
Closed
@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Apr 14, 2017
@facebook-github-bot
Copy link
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@facebook-github-bot facebook-github-bot added Import Failed Import Started This pull request has been imported. This does not imply the PR has been approved. and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Apr 15, 2017
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Maxwell2022 pushed a commit to Maxwell2022/react-native that referenced this pull request Apr 19, 2017
@mehcode
Use uri instead of url in source property of Image
05981c2 
Summary:
facebook#13478 (comment)

Fix incorrect usage of `url` in the `source` property of `<Image />` in the example.
Closes facebook#13496

Differential Revision: D4893299

Pulled By: hramos

fbshipit-source-id: 134f9100d16997627b14c145256818e05017bbe3
thotegowda pushed a commit to thotegowda/react-native that referenced this pull request May 7, 2017
@mehcode @thotegowda
Use uri instead of url in source property of Image
c327060 
Summary:
facebook#13478 (comment)

Fix incorrect usage of `url` in the `source` property of `<Image />` in the example.
Closes facebook#13496

Differential Revision: D4893299

Pulled By: hramos

fbshipit-source-id: 134f9100d16997627b14c145256818e05017bbe3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehcode @facebook-github-bot