Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

info for #4259 DO NOT MERGE #4258

Closed
wants to merge 8 commits into from
Closed

info for #4259 DO NOT MERGE #4258

wants to merge 8 commits into from

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Aug 26, 2017

No description provided.

@ofek
Copy link
Contributor Author

ofek commented Aug 26, 2017

@kennethreitz Hey there! Could you please re-open this? There is a hanging test I want to verify in CI.

@kennethreitz kennethreitz reopened this Aug 26, 2017
@kennethreitz
Copy link
Contributor

sorry!

@ofek ofek closed this Aug 26, 2017
@ofek ofek reopened this Aug 26, 2017
@ofek ofek mentioned this pull request Aug 26, 2017
Closed
@ofek ofek changed the title DO NOT MERGE DO NOT MERGE info for #4259 Aug 26, 2017
@ofek ofek changed the title DO NOT MERGE info for #4259 info for #4259 DO NOT MERGE Aug 26, 2017
@ofek
Copy link
Contributor Author

ofek commented Aug 26, 2017

@kennethreitz No problem! I submitted #4259

@Lukasa
Copy link
Member

Lukasa commented Aug 27, 2017

Ok, so the first note is that I don't reproduce this failure locally. That suggests that the failure is environmental: either OS-based (I'm on macOS) or something more nuanced. My first guess is that it's related to proxies, so I'm going to chase that rabbit hole.

@Lukasa
Copy link
Member

Lukasa commented Aug 27, 2017

Ok if we fail out of the mixed_case_scheme_acceptable test the next test hangs instead. Let me see if I can escape that one too.

@Lukasa
Copy link
Member

Lukasa commented Aug 27, 2017

Ok so what seems to be happening is that the HTTP server is blocking forever. Let's try to find out why.

@Lukasa
Copy link
Member

Lukasa commented Aug 27, 2017

Hrm, here's a weirdness: this doesn't appear to happen when I run the tests under tox.

@Lukasa
Copy link
Member

Lukasa commented Aug 27, 2017

Ohhhhh I know what this will be. Ok, one sec.

@Lukasa
Copy link
Member

Lukasa commented Aug 27, 2017

Yup, got it. Ok, will open a PR that fixes this problem.

@Lukasa Lukasa closed this Aug 27, 2017
@ofek
Copy link
Contributor Author

ofek commented Aug 27, 2017

Between this and that macOS memory allocation thing, you're the King of Bug Hunting!

@Lukasa
Copy link
Member

Lukasa commented Aug 27, 2017

Heh, thanks!

@kevin1024 kevin1024 mentioned this pull request Aug 27, 2017
Closed
kevin1024 added a commit to kevin1024/requests that referenced this pull request Aug 27, 2017
@kevin1024
unpin httpbin
d35014e 
The upstream bug has been fixed 

See also: 
* psf#4261
* psf#4258
* psf#4259
@kevin1024 kevin1024 mentioned this pull request Aug 27, 2017
Closed
@ofek ofek deleted the patch-1 branch April 22, 2019 15:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @kennethreitz @Lukasa