Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests are broken #4259

Closed
ofek opened this issue Aug 26, 2017 · 3 comments
Closed

tests are broken #4259

ofek opened this issue Aug 26, 2017 · 3 comments

Comments

@ofek
Copy link
Contributor

ofek commented Aug 26, 2017

Specifically, this hangs https://github.com/requests/requests/blob/5dcbdb50fc9652cbeffeec22a21d1196e938bfca/tests/test_requests.py#L151

It can be seen in #4258 https://travis-ci.org/requests/requests/jobs/268764155

This occurs locally for me as well.
@ofek ofek mentioned this issue Aug 26, 2017
Closed
@kennethreitz
Copy link
Contributor

I'm loving these new GitHub line previews.

@kennethreitz
Copy link
Contributor

So fancy!

@Lukasa Lukasa mentioned this issue Aug 27, 2017
Merged
@Lukasa
Copy link
Member

Lukasa commented Aug 27, 2017

See #4261.

kevin1024 added a commit to kevin1024/requests that referenced this issue Aug 27, 2017
@kevin1024
Try to fix hanging tests
27c27a6 
The tests are hanging sometimes, see psf#4259 and psf#4261.  I wonder if it would work to unpin both packages since I think I fixed a bug with pytest-httpbin hanging awhile back.
This was referenced Aug 27, 2017
Closed
Closed
kevin1024 added a commit to kevin1024/requests that referenced this issue Aug 27, 2017
@kevin1024
unpin httpbin
d35014e 
The upstream bug has been fixed 

See also: 
* psf#4261
* psf#4258
* psf#4259
@kevin1024 kevin1024 mentioned this issue Aug 27, 2017
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kennethreitz @Lukasa @ofek