-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requests 2.32.0 Not supported URL scheme http+docker #6707
Comments
I believe this was introduce with this line change which started enforcing the URL scheme: The issue is also being tracked over in |
Hi @joshzcold, could you clarify more about the expected functionality with a This appears to be a byproduct of fixing CVE-2024-35195. urllib3 is expecting the scheme to be either |
@nateprewitt do you think the fix in docker/docker-py#3257 is good enough for now, or do you have a suggestion for a better way to work around this problem, at least for now? I guess it would be great if Docker SDK for Python wouldn't need to depend on internal behavior of requests, but changing that in a proper way likely needs a larger rewrite / rearchitecturing of that part of Docker SDK for Python... |
Since it looks like docker-py needs apply the fix on their end I believe we can close this PR. |
We wrote the #6655 fix trying to avoid breaking users that were relying on the existing behavior of I don't think what I have a hunch |
|
I would guess requests-file or whichever fork of that is still maintained would be affected if anyone uses it |
It implements it very similarly to Docker SDK for Python, i.e. it also overwrites |
I don't know requests-file, but the code in https://github.com/dashea/requests-file overwrites |
to 2.31.0 to avoid the bug psf/requests#6707 .
Workaround for: psf/requests#6707 Signed-off-by: Ondra Machacek <[email protected]>
Workaround for: psf/requests#6707 Signed-off-by: Ondra Machacek <[email protected]>
Workaround for: psf/requests#6707 Signed-off-by: Ondra Machacek <[email protected]>
Workaround for: psf/requests#6707 Signed-off-by: Ondra Machacek <[email protected]>
See psf/requests#6707 Signed-off-by: Callahan Kovacs <[email protected]>
This should be resolved with docker-py 7.1.0, no longer requiring pinning Requests<2.32. I'll leave this open for a few more hours for comment and then plan to resolve this as completed by the end of today. |
See psf/requests#6707 Signed-off-by: Callahan Kovacs <[email protected]>
I am facing same issue with Docker-compose Can someone help me what are the exact commands I should follow to fix the issue? Some of the answers from the net says "pinning requests version to 2.31.0" I am a newbie, wondering what is pinning? how to do? I am using WSL2 , Ubuntu 22 LTS. Error Message I am receiving is below --> File "/home/rkk/.local/lib/python3.10/site-packages/requests/adapters.py", line 532, in send |
@rkkilari the old docker-compose Python package (which is End of Life for two years now!) does not work with Docker SDK for Python 7.1.0, which is the first version that works with Requests 2.32.x. You have to stick to Also please note that you installed both And to your actual question: pinning means that you make sure a fixed version is installed for a package. In this case, make sure that |
requests 2.32 introduce behavior break in validating scheme: psf/requests#6707 requests-unixsocket is no more maintained but a fork was put in place to fix the issue: msabramo/requests-unixsocket#73
requests 2.32 introduce behavior break in validating scheme: psf/requests#6707 requests-unixsocket is no more maintained but a fork was put in place to fix the issue: msabramo/requests-unixsocket#73
Newest version of requests 2.32.0 has an incompatibility with python lib
docker
Expected Result
Normal initalization of docker client
Actual Result
Stack trace posted above
Reproduction Steps
mkvirtualenv debug_issue pip install docker pip install 'requests>=2.32.0' python
System Information
The text was updated successfully, but these errors were encountered: